Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background color not consistent #14

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Mar 19, 2024

Issue

Screenshot 2024-03-19 at 17 19 21

Resolved

Screenshot 2024-03-19 at 17 19 03

Demo

Web

Screen.Recording.2024-03-26.at.14.32.25.mov

Mobile

Screen.Recording.2024-03-26.at.14.40.26.mov
Screen.Recording.2024-03-27.at.09.45.40.mov

Additional fix: Single date picker background

Before
Screenshot 2024-03-27 at 17 19 51
After
Screenshot 2024-03-27 at 17 21 04
Demo web

Screen.Recording.2024-03-27.at.17.21.21.mov

Demo mobile

Screen.Recording.2024-03-27.at.17.23.08.mov

@dab246
Copy link
Member

dab246 commented Mar 26, 2024

Please attach video demo for responsive web and mobile. Thanks

@tddang-linagora
Copy link
Contributor Author

Please attach video demo for responsive web and mobile. Thanks

Done

@hoangdat
Copy link
Member

hoangdat commented Mar 27, 2024

  • demo case focus in fields

@dab246
Copy link
Member

dab246 commented Mar 27, 2024

Screenshot 2024-03-27 at 16 50 34

We should fix this function too.

@tddang-linagora
Copy link
Contributor Author

Screenshot 2024-03-27 at 16 50 34

We should fix this function too.

Done

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dab246
Copy link
Member

dab246 commented Mar 27, 2024

  • Please rebase & squash commit

@tddang-linagora tddang-linagora force-pushed the fix/modal-background-color-consistency branch from 1f42870 to b50904d Compare March 28, 2024 01:36
@hoangdat hoangdat merged commit 8efda22 into master Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants