Skip to content

Commit

Permalink
Trigger dispose before onClose in BaseController
Browse files Browse the repository at this point in the history
  • Loading branch information
tddang-linagora committed Jun 24, 2024
1 parent 885a386 commit be8de4f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 6 additions & 0 deletions lib/features/base/base_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,10 @@ abstract class BaseController extends GetxController
authorizationInterceptors.clear();
await cachingManager.closeHive();
}

@override
void onClose() {
super.onClose();
dispose();
}
}
2 changes: 0 additions & 2 deletions lib/features/composer/presentation/composer_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ class ComposerController extends BaseController with DragDropFileMixin {
ButtonState _sendButtonState = ButtonState.enabled;

late Worker uploadInlineImageWorker;
late Worker dashboardViewStateWorker;
late bool _isEmailBodyLoaded;

ComposerController(
Expand Down Expand Up @@ -267,7 +266,6 @@ class ComposerController extends BaseController with DragDropFileMixin {
ccEmailAddressController.dispose();
bccEmailAddressController.dispose();
uploadInlineImageWorker.dispose();
dashboardViewStateWorker.dispose();
scrollController.dispose();
scrollControllerEmailAddress.removeListener(_scrollControllerEmailAddressListener);
scrollControllerEmailAddress.dispose();
Expand Down

0 comments on commit be8de4f

Please sign in to comment.