Skip to content

Commit

Permalink
TF-2806 Fix some warning from github action
Browse files Browse the repository at this point in the history
  • Loading branch information
dab246 committed May 13, 2024
1 parent 05754a0 commit e99e29a
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
3 changes: 2 additions & 1 deletion core/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ linter:
rules:
constant_identifier_names: false
non_constant_identifier_names: false
unnecessary_string_escapes: false
unnecessary_string_escapes: false
avoid_web_libraries_in_flutter: false
1 change: 0 additions & 1 deletion core/lib/presentation/resources/assets_paths.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
class AssetsPaths {
static const images = 'assets/images/';
static const icons = 'assets/icons/';
static const configurationImages = 'configurations/icons/';
}
4 changes: 0 additions & 4 deletions core/lib/presentation/resources/image_paths.dart
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,6 @@ class ImagePaths {
return AssetsPaths.images + imageName;
}

String _getIconPath(String iconName) {
return AssetsPaths.icons + iconName;
}

String getConfigurationImagePath(String imageName) {
return AssetsPaths.configurationImages + imageName;
}
Expand Down
3 changes: 2 additions & 1 deletion lib/features/email/presentation/utils/email_utils.dart
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@

import 'package:collection/collection.dart';
import 'package:core/presentation/state/failure.dart';
import 'package:core/presentation/state/success.dart';
import 'package:core/utils/app_logger.dart';
import 'package:get/get_utils/src/get_utils/get_utils.dart';
import 'package:core/core.dart';
import 'package:dartz/dartz.dart';
import 'package:jmap_dart_client/jmap/account_id.dart';
import 'package:jmap_dart_client/jmap/core/capability/capability_identifier.dart';
Expand Down
2 changes: 1 addition & 1 deletion pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ packages:
source: hosted
version: "6.1.4"
file_picker:
dependency: "direct overridden"
dependency: "direct main"
description:
path: "."
ref: "email_supported_5.3.1"
Expand Down
2 changes: 2 additions & 0 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ dependencies:

mime: 1.0.4

file_picker: 5.3.1

dev_dependencies:
flutter_test:
sdk: flutter
Expand Down

0 comments on commit e99e29a

Please sign in to comment.