Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving dependencies after upgrading to flutter 3.10.0 #1849

Open
MrOsamah opened this issue May 16, 2023 · 8 comments
Open

Resolving dependencies after upgrading to flutter 3.10.0 #1849

MrOsamah opened this issue May 16, 2023 · 8 comments
Assignees

Comments

@MrOsamah
Copy link

Hello,

After upgrading to Flutter 3.10.0
The flutter_test from sdk depends on collection 1.17.1, and core depends on collection 1.17.0.

Could you please resolve this?

Thanks

@dab246
Copy link
Member

dab246 commented Jul 4, 2023

@MrOsamah

You can create a PR to upgrade flutter version to 3.10.x for TMail for us. We would also love to upgrade to 3.10.x but don't have time for it yet, we'd appreciate it if you could. Thanks

@dab246 dab246 mentioned this issue Jul 4, 2023
@Arsnael
Copy link
Member

Arsnael commented Jul 5, 2023

@dab246 let me take a try at this one, if it can help :)

@Arsnael Arsnael self-assigned this Jul 5, 2023
@dab246
Copy link
Member

dab246 commented Jul 5, 2023

@dab246 let me take a try at this one, if it can help :)

I'm so happy about that. Let's go 👍

@Arsnael
Copy link
Member

Arsnael commented Jul 5, 2023

WIP:

./prebuild.sh works with those updates. But I still need to check the code as trying to run on android emulator fails to build. Will get back to it friday

@Arsnael
Copy link
Member

Arsnael commented Jul 13, 2023

The PR should be good for review now :)

@Arsnael
Copy link
Member

Arsnael commented Jul 25, 2023

I believe this can be closed, as the project has moved to Flutter 3.10.6, correct?

@hoangdat
Copy link
Member

please keep the main to prepare for customer issue. checkout main, merge 3.10.x and develop the new function on it. @dab246

@Arsnael
Copy link
Member

Arsnael commented Jul 25, 2023

Alright I forgot it was merged on an other branch indeed, thanks for the correction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants