Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] No need to suggest sending message to drafts when it's empty #3036

Open
tprudentova opened this issue Jul 24, 2024 · 4 comments

Comments

@tprudentova
Copy link
Collaborator

0.12.1 tested on Android, Firefox, Safari, Opera; mail.stg.lin-saas.com

  1. Open composer
  2. Click Close
  3. There's a suggestion to save email to Drafts. I believe it's not necessary when the user hasn't input anything in the composer
Screen.Recording.2024-07-24.at.14.25.09.mov
@hoangdat
Copy link
Member

hi @dab246, how we can distinguish the case of it? we should to consider carefully the signature in draft too

@dab246
Copy link
Member

dab246 commented Jul 26, 2024

hi @dab246, how we can distinguish the case of it? we should to consider carefully the signature in draft too

  • When doing Save As Draft. We should update the value of EmailActionType=editDraft. Moreover, we also have the function validateEmailChange to check if the email has changed or not. So we can handle this case.

@hoangdat
Copy link
Member

  • Case 1: new composer
  • Case 2: edit draft

Should add logic to compare identity to validate changes.

@dab246
Copy link
Member

dab246 commented Oct 4, 2024

Also fixed at #3184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants