Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flutter to v3.10.5 #2005

Closed

Conversation

Arsnael
Copy link
Member

@Arsnael Arsnael commented Jul 5, 2023

No description provided.

@Arsnael Arsnael self-assigned this Jul 5, 2023
@Arsnael
Copy link
Member Author

Arsnael commented Jul 5, 2023

So:

As both those libs are Linagora (well one is on @dab246 personal github actually)

By pointing to those libs modified locally as their respective PR, the ./prebuild.sh compile with Flutter 3.10.5.

I still have work to do as when I try to run it for Android emulator there is errors with code to fix. So it's still a WIP

pubspec.yaml Outdated Show resolved Hide resolved
@hoangdat
Copy link
Member

hoangdat commented Jul 5, 2023

I propose to merge to branch upgrade_3_10_x, and test all the thing on it before merge to master branch. Thanks

@hoangdat hoangdat changed the base branch from master to upgrade_3_10_x July 5, 2023 11:02
@Arsnael Arsnael marked this pull request as ready for review July 13, 2023 09:57
@Arsnael
Copy link
Member Author

Arsnael commented Jul 13, 2023

cc @dab246 @hoangdat

I can:

  • compile with prebuild.sh
  • run the app with an android emulator with flutter run
  • build and run tmail-web

I do not have a macbook so I can't check for iOS app though. I didn't test too much though.

Of course the last commit should be removed when the 2 other projects have been merged/released with necessary changes for upgrading to flutter 3.10.5.

If any remarks or feedback, don't hesitate :)

@tk-nguyen
Copy link
Collaborator

tk-nguyen commented Jul 13, 2023

FYI, just ignore the failing Deploy PR on Github Pages check. Because this is running from a fork, so this workflow cannot access secrets.

@dab246
Copy link
Member

dab246 commented Jul 17, 2023

I will close this PR. Please follow the full PR upgrade at #2036

@dab246 dab246 closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants