Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-2047 [Link] Can not see the link when type is text/plain in email view #2060

Merged
merged 9 commits into from
Aug 3, 2023

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Jul 31, 2023

Issues

Root cause

  • Because we perform html escape before creating autolink, it makes lost tags undetectable.
  • Moreover, the detect function is ignored in some cases

Resolved

Screen.Recording.2023-07-31.at.17.59.04.online-video-cutter.com.mp4

@dab246 dab246 temporarily deployed to PR-2060 July 31, 2023 11:17 — with GitHub Actions Inactive
@github-actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2060.

@dab246 dab246 temporarily deployed to PR-2060 August 1, 2023 03:40 — with GitHub Actions Inactive
@dab246 dab246 changed the base branch from master to upgrade_3_10_x August 1, 2023 05:39
@dab246 dab246 force-pushed the fix/tf-2047-can-not-auto-link branch from 8978a8d to 2944949 Compare August 1, 2023 05:42
@dab246 dab246 temporarily deployed to PR-2060 August 1, 2023 05:42 — with GitHub Actions Inactive
@dab246 dab246 temporarily deployed to PR-2060 August 1, 2023 05:57 — with GitHub Actions Inactive
@dab246 dab246 requested a review from drminh2807 August 1, 2023 05:57
@dab246 dab246 merged commit f68e65b into upgrade_3_10_x Aug 3, 2023
9 checks passed
@dab246 dab246 deleted the fix/tf-2047-can-not-auto-link branch August 14, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants