Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-1946,1947 Swipe left in item of Thread View #2105

Merged
merged 1 commit into from
Aug 29, 2023
Merged

TF-1946,1947 Swipe left in item of Thread View #2105

merged 1 commit into from
Aug 29, 2023

Conversation

hieutbui
Copy link
Member

@hieutbui hieutbui commented Aug 22, 2023 •
edited by dab246
Loading

Issue

#1946
#1947

Solution

  • Use Dismissible to make item can swipe

Resolved

  • Mobile
tm-1946.demo.mobile.mp4
  • Web
tf-1946.demo.mp4

@hieutbui hieutbui temporarily deployed to PR-2105 August 22, 2023 05:04 — with GitHub Actions Inactive
@dab246
Copy link
Member

dab246 commented Aug 22, 2023

Screenshot 2023-08-22 at 12 06 58

This is feature not bug, so we not need root causes

@github-actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2105.

@dab246
Copy link
Member

dab246 commented Aug 22, 2023

Disable swipe on web desktop

@hoangdat
Copy link
Member

please guide him
image

@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 12:59 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 13:12 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 13:29 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 13:47 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 17:12 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 17:54 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 17:57 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 17:58 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 23, 2023 18:18 — with GitHub Actions Inactive
@hoangdat
Copy link
Member

can you show the demo for web app in mobile/tablet/desktop screen

dab246
dab246 reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to create circle icon, you can use CircleAvatar

lib/features/thread/presentation/thread_view.dart Outdated Show resolved Hide resolved
lib/features/thread/presentation/thread_view.dart Outdated Show resolved Hide resolved
@hieutbui hieutbui temporarily deployed to PR-2105 August 24, 2023 10:42 — with GitHub Actions Inactive
@hieutbui
Copy link
Member Author

hieutbui commented Aug 24, 2023 •
edited
Loading

can you show the demo for web app in mobile/tablet/desktop screen
@hoangdat please watch video below:

tf-1946-demo.mp4

@hieutbui hieutbui temporarily deployed to PR-2105 August 24, 2023 15:59 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 25, 2023 03:56 — with GitHub Actions Inactive
@hieutbui
Copy link
Member Author

If you want to create circle icon, you can use CircleAvatar

@dab246 I have changed it to CircleAvatar instead.

@hieutbui hieutbui temporarily deployed to PR-2105 August 25, 2023 05:06 — with GitHub Actions Inactive
@dab246
Copy link
Member

dab246 commented Aug 25, 2023

Note: @hieutbui

  1. Update video demo for Mobile/Tablet/Web(Responsive)
  2. Squash commit use git commit --squash
  3. Fix comment use git commit --fixup

@hieutbui hieutbui force-pushed the feature/tf-1946-swipe-left-in-unread-item-of-threadview branch from 7e7143e to ada6757 Compare August 27, 2023 16:40
@hieutbui hieutbui temporarily deployed to PR-2105 August 27, 2023 16:40 — with GitHub Actions Inactive
@dab246
Copy link
Member

dab246 commented Aug 28, 2023

@hieutbui Please rebase master then force-pushed
Screenshot 2023-08-28 at 09 25 44

@hieutbui hieutbui force-pushed the feature/tf-1946-swipe-left-in-unread-item-of-threadview branch from 95e6ff2 to 9ef1102 Compare August 28, 2023 03:22
@hieutbui hieutbui temporarily deployed to PR-2105 August 28, 2023 03:22 — with GitHub Actions Inactive
@dab246
Copy link
Member

dab246 commented Aug 28, 2023

Fix duplicate import avoid build failed on CI

Screenshot 2023-08-28 at 10 40 36

Arsnael
Arsnael reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@Arsnael Arsnael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it

@hoangdat hoangdat added the good first issue Good for newcomers label Aug 28, 2023
@hieutbui hieutbui temporarily deployed to PR-2105 August 28, 2023 07:52 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 28, 2023 10:13 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 28, 2023 10:43 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 28, 2023 10:46 — with GitHub Actions Inactive
@hieutbui hieutbui force-pushed the feature/tf-1946-swipe-left-in-unread-item-of-threadview branch from e2ae90c to 2aeb3b3 Compare August 28, 2023 10:48
@hieutbui hieutbui temporarily deployed to PR-2105 August 28, 2023 10:48 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2105 August 28, 2023 10:49 — with GitHub Actions Inactive
@dab246 dab246 changed the title TF-1946 Swipe left in item of Thread View TF-1946,1947 Swipe left in item of Thread View Aug 28, 2023
@dab246
Copy link
Member

dab246 commented Aug 28, 2023 •
edited
Loading

@hieutbui Please squash all --fixup commit and then rebase it

@hieutbui
tf-1946 add swipe to thread
780ba1d 
tf-1946 add swipe to thread

tf-1946 fix duplicate import and change MarkReadAction
@hieutbui hieutbui force-pushed the feature/tf-1946-swipe-left-in-unread-item-of-threadview branch from 85998b2 to 780ba1d Compare August 28, 2023 12:45
@hieutbui
Copy link
Member Author

@hieutbui Please squash all --fixup commit and then rebase it

It's done!

dab246
dab246 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dab246 dab246 merged commit 3fa17e2 into master Aug 29, 2023
9 checks passed
@dab246 dab246 deleted the feature/tf-1946-swipe-left-in-unread-item-of-threadview branch September 11, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arsnael Arsnael Arsnael left review comments

@sherlockvn sherlockvn sherlockvn left review comments

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 dab246 approved these changes

@drminh2807 drminh2807 Awaiting requested review from drminh2807

@nqhhdev nqhhdev Awaiting requested review from nqhhdev

Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hieutbui @dab246 @hoangdat @Arsnael @sherlockvn