Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-2083 Add/remove conditions in UI #2117

Conversation

hieutbui
Copy link
Member

@hieutbui hieutbui commented Aug 31, 2023

Issue


#2083

Resolved


TF-2083.demo.mp4

@hieutbui hieutbui temporarily deployed to PR-2117 August 31, 2023 08:49 — with GitHub Actions Inactive
@github-actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2117.

@hieutbui hieutbui force-pushed the feature/TF-2083-Implement-add-and-remove-conditions-in-UI-of-Rule-Filter branch from b2960ad to 1831863 Compare September 6, 2023 03:43
@hieutbui hieutbui temporarily deployed to PR-2117 September 6, 2023 03:43 — with GitHub Actions Inactive
Copy link
Member

@Arsnael Arsnael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tagging me, was interesting to read.

There is maybe a concern I have, but maybe I misunderstood something (in case don't hesitate to tell me so).

I feel like in the end, when creating multiple conditions on a rule, what you seem to send (but maybe I'm wrong) to the tmail backend is a list of rules corresponding to each condition, while actually the backend would I think expect getting only one rule, but with the multiple conditions.

I would be curious to see a video where you click on the create button after adding a few conditions to your rules and see if you get a list of rules or just one rule, and then seeing if when you try to edit if everything gets back?

Also on the video: mobile version I did not see the removal button on conditions

Otherwise good job :)

@Arsnael
Copy link
Member

Arsnael commented Sep 6, 2023

Ah nvm I just reread the title, it's only for the UI so far correct, so the rest about the logic with the backend is gonna be in an other PR?

@hieutbui
Copy link
Member Author

hieutbui commented Sep 6, 2023

Ah nvm I just reread the title, it's only for the UI so far correct, so the rest about the logic with the backend is gonna be in an other PR?

Yeah, it will be handled in the next PR

@hieutbui hieutbui temporarily deployed to PR-2117 September 6, 2023 11:56 — with GitHub Actions Inactive
@hieutbui hieutbui changed the title [WIP] TF-2083 Add/remove conditions in UI TF-2083 Add/remove conditions in UI Sep 6, 2023
@hieutbui hieutbui temporarily deployed to PR-2117 September 7, 2023 02:28 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2117 September 7, 2023 05:27 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2117 September 8, 2023 05:12 — with GitHub Actions Inactive
@hieutbui hieutbui force-pushed the feature/TF-2083-Implement-add-and-remove-conditions-in-UI-of-Rule-Filter branch from 8b8eadd to de06ee4 Compare September 8, 2023 05:17
@hieutbui hieutbui temporarily deployed to PR-2117 September 8, 2023 05:17 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2117 September 8, 2023 08:18 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2117 September 11, 2023 02:14 — with GitHub Actions Inactive
@hieutbui hieutbui force-pushed the feature/TF-2083-Implement-add-and-remove-conditions-in-UI-of-Rule-Filter branch from 62a1bc0 to a6287b8 Compare September 11, 2023 02:15
@hieutbui hieutbui temporarily deployed to PR-2117 September 11, 2023 02:15 — with GitHub Actions Inactive
@hieutbui hieutbui temporarily deployed to PR-2117 September 11, 2023 04:13 — with GitHub Actions Inactive
@hieutbui hieutbui force-pushed the feature/TF-2083-Implement-add-and-remove-conditions-in-UI-of-Rule-Filter branch from f34b04c to f663950 Compare September 11, 2023 05:04
@hieutbui hieutbui temporarily deployed to PR-2117 September 11, 2023 05:04 — with GitHub Actions Inactive
@hieutbui hieutbui force-pushed the feature/TF-2083-Implement-add-and-remove-conditions-in-UI-of-Rule-Filter branch from f663950 to 3565bdc Compare September 11, 2023 05:10
@hieutbui hieutbui temporarily deployed to PR-2117 September 11, 2023 05:10 — with GitHub Actions Inactive
@hieutbui hieutbui force-pushed the feature/TF-2083-Implement-add-and-remove-conditions-in-UI-of-Rule-Filter branch from 3565bdc to 3f12c25 Compare September 11, 2023 07:54
@hieutbui hieutbui temporarily deployed to PR-2117 September 11, 2023 07:54 — with GitHub Actions Inactive
@hieutbui hieutbui force-pushed the feature/TF-2083-Implement-add-and-remove-conditions-in-UI-of-Rule-Filter branch from 3f12c25 to 48c8a99 Compare September 11, 2023 07:56
@dab246 dab246 merged commit 40ebc31 into master Sep 11, 2023
9 checks passed
@hoangdat hoangdat deleted the feature/TF-2083-Implement-add-and-remove-conditions-in-UI-of-Rule-Filter branch February 20, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants