-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-2083 Add/remove conditions in UI #2117
TF-2083 Add/remove conditions in UI #2117
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/2117. |
lib/features/rules_filter_creator/presentation/model/rule_filter_condition_type.dart
Outdated
Show resolved
Hide resolved
b2960ad
to
1831863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tagging me, was interesting to read.
There is maybe a concern I have, but maybe I misunderstood something (in case don't hesitate to tell me so).
I feel like in the end, when creating multiple conditions on a rule, what you seem to send (but maybe I'm wrong) to the tmail backend is a list of rules corresponding to each condition, while actually the backend would I think expect getting only one rule, but with the multiple conditions.
I would be curious to see a video where you click on the create button after adding a few conditions to your rules and see if you get a list of rules or just one rule, and then seeing if when you try to edit if everything gets back?
Also on the video: mobile version I did not see the removal button on conditions
Otherwise good job :)
Ah nvm I just reread the title, it's only for the UI so far correct, so the rest about the logic with the backend is gonna be in an other PR? |
Yeah, it will be handled in the next PR |
lib/features/rules_filter_creator/presentation/rules_filter_creator_controller.dart
Outdated
Show resolved
Hide resolved
lib/features/rules_filter_creator/presentation/rules_filter_creator_view.dart
Outdated
Show resolved
Hide resolved
lib/features/rules_filter_creator/presentation/rules_filter_creator_controller.dart
Outdated
Show resolved
Hide resolved
lib/features/rules_filter_creator/presentation/rules_filter_creator_controller.dart
Outdated
Show resolved
Hide resolved
8b8eadd
to
de06ee4
Compare
lib/features/rules_filter_creator/presentation/model/rules_filter_input_field_arguments.dart
Outdated
Show resolved
Hide resolved
lib/features/rules_filter_creator/presentation/rules_filter_creator_controller.dart
Outdated
Show resolved
Hide resolved
lib/features/rules_filter_creator/presentation/model/rules_filter_input_field_arguments.dart
Outdated
Show resolved
Hide resolved
62a1bc0
to
a6287b8
Compare
lib/features/rules_filter_creator/presentation/widgets/rule_filter_condition_widget.dart
Outdated
Show resolved
Hide resolved
lib/features/rules_filter_creator/presentation/widgets/rule_filter_condition_widget.dart
Outdated
Show resolved
Hide resolved
lib/features/rules_filter_creator/presentation/model/rules_filter_input_field_arguments.dart
Outdated
Show resolved
Hide resolved
f34b04c
to
f663950
Compare
f663950
to
3565bdc
Compare
...s/rules_filter_creator/presentation/widgets/rule_filter_condition_remove_button_builder.dart
Outdated
Show resolved
Hide resolved
lib/features/rules_filter_creator/presentation/widgets/rule_filter_condition_row_builder.dart
Outdated
Show resolved
Hide resolved
3565bdc
to
3f12c25
Compare
3f12c25
to
48c8a99
Compare
Issue
#2083
Resolved
TF-2083.demo.mp4