TF-2129 Fix cannot attach file on mobile #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dab246
requested review from
hoangdat,
nqhhdev,
sherlockvn,
drminh2807 and
hieutbui
sherlockvn
reviewed
Sep 7, 2023
nqhhdev
approved these changes
Sep 7, 2023
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/2132. |
hoangdat
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2129
Root cause
3.10.6and dart3.0.0. Dart SDK have tightened the rules for which objects can be sent across isolates (see https://api.dart.dev/stable/3.0.0/dart-isolate/SendPort/send.html and dart-lang/sdk@67683c39)Resolved
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-09-07.at.15.20.16.mp4