Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOT-FIX] Fix refresh token with oidc on upn #2133

Merged
merged 2 commits into from
Sep 11, 2023
Merged

[HOT-FIX] Fix refresh token with oidc on upn #2133

merged 2 commits into from
Sep 11, 2023

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Sep 8, 2023

Issue

#1974

Root cause

  • When executing tasks concurrently, they are pushed into the queue along with the old header values (the old authentication is retained). So when the first request receives a 401 error and tries to get a new token, it will be updated with the new authentication-header value.

Resolved

demo.mp4

@dab246 dab246 temporarily deployed to PR-2133 September 8, 2023 13:02 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR has been deployed to https://linagora.github.io/tmail-flutter/2133.

@hoangdat
Copy link
Member

hoangdat commented Sep 8, 2023

Can you write it and the implementation of queue interceptor in ADR. Thanks

@dab246 dab246 merged commit f50bc50 into master Sep 11, 2023
9 checks passed
@hoangdat hoangdat deleted the hotfix/fix-refresh-token-on-upn-mobile branch February 20, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@nqhhdev nqhhdev Awaiting requested review from nqhhdev

@sherlockvn sherlockvn Awaiting requested review from sherlockvn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dab246 @hoangdat