Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Playwright for Flutter Web #2993

Merged
merged 27 commits into from
Aug 7, 2024
Merged

Add Playwright for Flutter Web #2993

merged 27 commits into from
Aug 7, 2024

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora self-assigned this Jul 10, 2024
@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2993.

chibenwa
chibenwa reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about tmail_e2e instead of tmail_selenium then?

@tddang-linagora tddang-linagora changed the title Create POC Selenium for Flutter Web [WIP] Create POC Playwright for Flutter Web Jul 16, 2024
@tddang-linagora tddang-linagora marked this pull request as draft July 16, 2024 03:25
@tddang-linagora tddang-linagora changed the base branch from refactor to sprint_25_flutter_3_22_2 July 18, 2024 04:10
@hoangdat
Copy link
Member

fix for the different in baseUrl and apiUrl #3027

@quantranhong1999
Copy link
Member

@tddang-linagora My test container work branch: https://github.com/quantranhong1999/tmail-flutter/commits/poc/selenium_testcontainer/

Do not hesitate to cherry-pick the latest commits and validate the work.

Cheers.

@quantranhong1999
Copy link
Member

quantranhong1999 commented Jul 25, 2024 •
edited
Loading

cc @tk-nguyen likely you would need to set an ENV variable to store the latest image built by the CI, so the E2E testing phase can get the image tag and run later.

cf quantranhong1999@a6b3e4e#diff-a6f0c8545d1ac34ef4ea20cd3acbda7a7de3d06b17a6b660293a7f47d2272cc9R86

@tk-nguyen
Copy link
Collaborator

tk-nguyen commented Jul 25, 2024 •
edited
Loading

cc @tk-nguyen likely you would need to set an ENV variable to store the latest image built by the CI, so the E2E testing phase can get the image tag and run later.

cf quantranhong1999@a6b3e4e#diff-a6f0c8545d1ac34ef4ea20cd3acbda7a7de3d06b17a6b660293a7f47d2272cc9R86

We build a local image named tmail-web:integration-test with each E2E workflow

https://github.com/linagora/tmail-flutter/pull/2993/files#diff-b6766eb8febc0c51651250cd0cdfb44c4f0d3256470d88e62bf82fd46aa73ae0R36

@quantranhong1999
Copy link
Member

We build an image named tmail-web:integration-test with each E2E workflow

Ok I can hard code that image tag then.

@hoangdat hoangdat changed the title [WIP] Create POC Playwright for Flutter Web Create POC Playwright for Flutter Web Aug 6, 2024
@tddang-linagora tddang-linagora marked this pull request as ready for review August 6, 2024 05:08
@hoangdat hoangdat changed the title Create POC Playwright for Flutter Web Add Playwright for Flutter Web Aug 6, 2024
@hoangdat hoangdat merged commit 85effbc into sprint_25_flutter_3_22_2 Aug 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa left review comments

@dab246 dab246 dab246 left review comments

@hoangdat hoangdat Awaiting requested review from hoangdat

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tddang-linagora @hoangdat @quantranhong1999 @tk-nguyen @chibenwa @dab246