Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3150 Fix cancel sending email not work as expected #3186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Oct 1, 2024

Issue

#3150

Resolved

  • Web: Sending email
sending-email.mov
  • Web: Saving email as draft
saving-email.mov
  • Mobile: Sending email
send-mobile.webm
  • Mobile: Saving email as draft
save-mobile.webm

Copy link

github-actions bot commented Oct 1, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3186.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also resetTimeout of Dio when dispose composer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we don't need to do that. The default timeout of dio is null. We only change it for the send email request and reset it as soon as the request is done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it is a singleton, I worry sometime we can not reset timeout, I want to make sure it will be reset ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dab246 dab246 force-pushed the bugfix/tf-3150-cancel-sending-email-not-work-as-expected branch from e143848 to df7c151 Compare October 15, 2024 05:15
@dab246 dab246 requested a review from hoangdat October 15, 2024 05:15
@hoangdat
Copy link
Member

hoangdat commented Oct 21, 2024

  • saving/sending request was canceled, but progress dialog can not be closed

Reproduce:

  1. Setup timeout 100ms
  2. composer email
  3. saving email
  4. timeout warning was shown
  5. save again
  6. composer new
  7. saving email
    => progress cannot be close because jmap request was canceling

@dab246 dab246 force-pushed the bugfix/tf-3150-cancel-sending-email-not-work-as-expected branch from 0a91583 to 6e41e80 Compare October 21, 2024 09:23
@dab246 dab246 force-pushed the bugfix/tf-3150-cancel-sending-email-not-work-as-expected branch from 6e41e80 to bd63898 Compare October 21, 2024 09:26
@dab246
Copy link
Member Author

dab246 commented Oct 21, 2024

  • saving/sending request was canceled, but progress dialog can not be closed

Reproduce:

  1. Setup timeout 100ms
  2. composer email
  3. saving email
  4. timeout warning was shown
  5. save again
  6. composer new
  7. saving email
    => progress cannot be close because jmap request was canceling

Fixed.

  • Use timeout of Future to avoid duplicated request delay in interceptor dio
Screen.Recording.2024-10-21.at.16.12.51.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants