-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-3150 Fix cancel sending email not work as expected #3186
base: master
Are you sure you want to change the base?
TF-3150 Fix cancel sending email not work as expected #3186
Conversation
This PR has been deployed to https://linagora.github.io/tmail-flutter/3186. |
lib/features/composer/domain/usecases/create_new_and_save_email_to_drafts_interactor.dart
Outdated
Show resolved
Hide resolved
lib/features/composer/domain/usecases/create_new_and_send_email_interactor.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also resetTimeout
of Dio
when dispose composer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we don't need to do that. The default timeout
of dio is null
. We only change it for the send email request and reset it as soon as the request is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it is a singleton, I worry sometime we can not reset timeout, I want to make sure it will be reset ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
e143848
to
df7c151
Compare
Reproduce:
|
0a91583
to
6e41e80
Compare
6e41e80
to
bd63898
Compare
Fixed.
Screen.Recording.2024-10-21.at.16.12.51.mov |
Issue
#3150
Resolved
sending-email.mov
saving-email.mov
send-mobile.webm
save-mobile.webm