Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the prebuild script #3195

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Simplify the prebuild script #3195

merged 1 commit into from
Oct 11, 2024

Conversation

tk-nguyen
Copy link
Collaborator

@tk-nguyen tk-nguyen commented Oct 8, 2024 •
edited
Loading

Detect existence of pubspec.yaml instead of hardcoding module names.

@tk-nguyen tk-nguyen changed the title Simplified the prebuild script Simplify the prebuild script Oct 8, 2024
dab246
dab246 reviewed Oct 8, 2024
View reviewed changes
scripts/prebuild.sh Outdated Show resolved Hide resolved
hoangdat
hoangdat reviewed Oct 9, 2024
View reviewed changes
scripts/prebuild.sh Outdated Show resolved Hide resolved
@tk-nguyen tk-nguyen closed this Oct 9, 2024
@tk-nguyen tk-nguyen reopened this Oct 9, 2024
@dab246
Copy link
Member

dab246 commented Oct 9, 2024

  • Squash it to one commit

@tk-nguyen
Copy link
Collaborator Author

tk-nguyen commented Oct 9, 2024 •
edited
Loading

  • Squash it to one commit

Done.

@hoangdat hoangdat merged commit 5cb6541 into master Oct 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dab246 dab246 dab246 left review comments

@hoangdat hoangdat hoangdat approved these changes

@tddang-linagora tddang-linagora tddang-linagora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tk-nguyen @dab246 @hoangdat @tddang-linagora