Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus problem when tab on Login Screen #3211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions contact/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,11 @@ packages:
flutter_typeahead:
dependency: transitive
description:
name: flutter_typeahead
sha256: ef2dd5a505d2d95a5b4c571c81ad2d6e7955f583dddec49064fec57acffd7a96
url: "https://pub.dev"
source: hosted
path: "."
ref: "fix/5.0.2-textfield-tab"
resolved-ref: e7d4cf334fce888a45e0b7ac7c178be33fd176a6
url: "https://github.com/linagora/flutter_typeahead.git"
source: git
version: "5.0.2"
flutter_web_plugins:
dependency: transitive
Expand Down
9 changes: 5 additions & 4 deletions core/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -534,10 +534,11 @@ packages:
flutter_typeahead:
dependency: "direct main"
description:
name: flutter_typeahead
sha256: ef2dd5a505d2d95a5b4c571c81ad2d6e7955f583dddec49064fec57acffd7a96
url: "https://pub.dev"
source: hosted
path: "."
ref: "fix/5.0.2-textfield-tab"
resolved-ref: e7d4cf334fce888a45e0b7ac7c178be33fd176a6
url: "https://github.com/linagora/flutter_typeahead.git"
source: git
version: "5.0.2"
flutter_web_plugins:
dependency: transitive
Expand Down
12 changes: 8 additions & 4 deletions core/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,12 @@ dependencies:

intl: 0.19.0

flutter_typeahead: 5.0.2
# TODO update with official fix
# when https://github.com/AbdulRahmanAlHamali/flutter_typeahead/issues/607 is resolved
flutter_typeahead:
git:
url: https://github.com/linagora/flutter_typeahead.git
ref: fix/5.0.2-textfield-tab

linkify: 5.0.0

Expand All @@ -101,7 +106,7 @@ dev_dependencies:

build_runner: 2.3.3

mockito: 5.4.4
mockito: 5.4.4
# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

Expand Down Expand Up @@ -143,10 +148,9 @@ flutter:
# For details regarding fonts from package dependencies,
# see https://flutter.dev/custom-fonts/#from-packages


# This section identifies your Flutter project as a module meant for
# embedding in a native host app. These identifiers should _not_ ordinarily
# be changed after generation - they are used to ensure that the tooling can
# maintain consistency when adding or modifying assets and plugins.
# They also do not have any bearing on your native host application's
# identifiers, which may be completely independent or the same as these.
# identifiers, which may be completely independent or the same as these.
22 changes: 22 additions & 0 deletions docs/adr/0053-focus-fix-on-type-ahead-field.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# 53. Focus fix on TypeAheadField

Date: 2024-10-21

## Status

Accepted

## Context

- Twake Mail use flutter_typeahead library to suggest result when user type in text field
- TypeAheadField of flutter_typeahead's logic of Focus handling has error, which results in user cannot use "Tab" key to move from one text field to another

## Decision

- Fork the library and update the source code at https://github.com/linagora/flutter_typeahead/tree/fix/5.0.2-textfield-tab, then use the fork dependency
- Open an issue at https://github.com/AbdulRahmanAlHamali/flutter_typeahead/issues/607

## Consequences

- The Focus is properly handled
- Fork dependency will be replaced by official fix once the above issue is resolved
9 changes: 5 additions & 4 deletions model/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,11 @@ packages:
flutter_typeahead:
dependency: transitive
description:
name: flutter_typeahead
sha256: ef2dd5a505d2d95a5b4c571c81ad2d6e7955f583dddec49064fec57acffd7a96
url: "https://pub.dev"
source: hosted
path: "."
ref: "fix/5.0.2-textfield-tab"
resolved-ref: e7d4cf334fce888a45e0b7ac7c178be33fd176a6
url: "https://github.com/linagora/flutter_typeahead.git"
source: git
version: "5.0.2"
flutter_web_plugins:
dependency: transitive
Expand Down
9 changes: 5 additions & 4 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1037,10 +1037,11 @@ packages:
flutter_typeahead:
dependency: "direct main"
description:
name: flutter_typeahead
sha256: ef2dd5a505d2d95a5b4c571c81ad2d6e7955f583dddec49064fec57acffd7a96
url: "https://pub.dev"
source: hosted
path: "."
ref: "fix/5.0.2-textfield-tab"
resolved-ref: e7d4cf334fce888a45e0b7ac7c178be33fd176a6
url: "https://github.com/linagora/flutter_typeahead.git"
source: git
version: "5.0.2"
flutter_web_plugins:
dependency: transitive
Expand Down
7 changes: 6 additions & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,12 @@ dependencies:

workmanager: 0.5.1

flutter_typeahead: 5.0.2
# TODO update with official fix
# when https://github.com/AbdulRahmanAlHamali/flutter_typeahead/issues/607 is resolved
flutter_typeahead:
git:
url: https://github.com/linagora/flutter_typeahead.git
ref: fix/5.0.2-textfield-tab

flutter_keyboard_visibility: 6.0.0

Expand Down
Loading