Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3D links not work on mobile #3220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix 3D links not work on mobile #3220

wants to merge 1 commit into from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Oct 22, 2024 •
edited
Loading

Issue

This PR #2917 solved 3D links on web, but still not working on mobile.

reproduce.webm

Root cause

  • Because the value useTooltip=true is only true on the web. So sanitizeUrl only handle for web

Solution

  • Separate sanitizeUrl handling to apply to both mobile and web.
  • Clear email cache avoid emails content being loaded from storage.

Resolved

demo.webm

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dab246 @tddang-linagora