-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-1902 update chat list item ui (Part 2) #1949
Conversation
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1949 |
For preview image in chat list latest message, you have to create a function like the function |
If you want a pair. please ping me |
it works well in iOS device, one small thing, can you make the splash full item or at least make it center ? it looks better IMO RPReplay_Final1724405603.MP4 |
ddf08d0
to
279417c
Compare
@KhaledNjim, can you do this one, also video preview the design has been updated, you can do it in the part III i think |
splashFix.webm |
i added video preview |
mainAxisAlignment: MainAxisAlignment.center, | ||
children: [ | ||
ChatListItemTitle(room: room), | ||
ChatListItemTitle( | ||
room: room, | ||
textStyle: LinagoraTextStyle.material().bodyMedium2, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static const EdgeInsets paddingConversation = EdgeInsets.fromLTRB( | ||
8, | ||
8, | ||
8, | ||
0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- avatar must be in the center of chat list item
ChatListItemTitle(room: room), | ||
ChatListItemTitle( | ||
room: room, | ||
textStyle: LinagoraTextStyle.material().bodyMedium2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use: Theme.of(context).textTheme.bodyMedium
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi @KhaledNjim, The padding is huge, think about it. Can you align it to the Avatar? |
One more: In |
When I'm using to hover in chat list item, UI/UX is pretty bad because of the huge white space! Simulator.Screen.Recording.-.iPhone.15.-.2024-09-16.at.09.22.42.mp4 |
|
8ae36ed
to
c942a15
Compare
|
TW-1902 update icons, text style TW-1920 add delivery state for chatlist items TW-1902 added image preview in chat_list TW-1902 added video preview for chat list items TW-1902 fixed bottom navigation avatar sync
c942a15
to
0051826
Compare
Ticket
#1902
Figma
Impact description
chat list items design updated
Test recommendations
test on all supported platforms with different sized screens
Resolved
-Web:
2024-07-23.16-46-24.mp4