-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tw 2026 update settings UI #2040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaledNjim
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
hieutbui,
tddang-linagora and
Te-Z
as code owners
September 22, 2024 23:21
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2040 |
pleaase rebase, your branch is outdated |
hoangdat
reviewed
Sep 24, 2024
KhaledNjim
force-pushed
the
TW-2005-update-settings-ui
branch
from
September 24, 2024 08:31
963f827
to
58ad733
Compare
done |
LGTM |
nqhhdev
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hoangdat
approved these changes
Sep 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2026
Impact description
Settings screen UI updated
Resolved
Attach screenshots or videos demonstrating the changes
Web:
Android:
IOS: