Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-2085 Change texts in settings screen #2086

Merged
merged 2 commits into from
Oct 16, 2024
Merged

TW-2085 Change texts in settings screen #2086

merged 2 commits into from
Oct 16, 2024

Conversation

KhaledNjim
Copy link
Contributor

@KhaledNjim KhaledNjim commented Oct 15, 2024 •
edited
Loading

Ticket

#2085

Root cause

Impact description

  • Change text to “Disable notifications” when the toggle is on and “Enable notifications” when the toggle is off
  • Change colour of the headers in Notifications screen
  • Remove description in app language
  • Remove all the descriptions for blocks in Settings
  • Change name of the block to just “Notifications”

Resolved

  • Web:
2085.mp4

@nqhhdev
Copy link
Member

nqhhdev commented Oct 16, 2024

hi @KhaledNjim should resolve conflict

@hoangdat
Copy link
Member

image @KhaledNjim please keep title `Notifications` in Center, the same for other settings

@hoangdat
Copy link
Member

hoangdat commented Oct 16, 2024 •
edited by KhaledNjim
Loading

  • changing icon app in appbar of web app only

@KhaledNjim
Copy link
Contributor Author

  • changing icon app in appbar of web app only

image

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2086

@hoangdat hoangdat merged commit 2eaa1db into main Oct 16, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-2085_text_updates branch October 16, 2024 17:43
@nqhhdev nqhhdev mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@nqhhdev nqhhdev nqhhdev approved these changes

@sherlockvn sherlockvn Awaiting requested review from sherlockvn sherlockvn is a code owner

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@hieutbui hieutbui Awaiting requested review from hieutbui hieutbui is a code owner

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora tddang-linagora is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhaledNjim @nqhhdev @hoangdat