Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove encryption and public/private #306

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Conversation

imGok
Copy link
Contributor

@imGok imGok commented Jul 12, 2023

@@ -23,7 +23,7 @@ class ExpansionParticipantsList extends StatefulWidget {
}

class _ExpansionParticipantsListState extends State<ExpansionParticipantsList> {
bool isExpanded = false;
bool isExpanded = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you change it, i set it default to be false because, when have a long list, it will auto scroll down a little bit, so user can't see group image, so i set default to false. Please check the case when have a lot of contacts also

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should found another way to solve that, we need to expand it by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it because imo it was better UI now we removed settings tiles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working atm with many contacts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wjhat is not working ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherlockvn it looks like it was a build error, it's working now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expandablelist

@hoangdat
Copy link
Member

Please keep the fixed size for the Group information. Only scroll for the list of participant @imGok

@imGok
Copy link
Contributor Author

imGok commented Jul 13, 2023

@hoangdat
expandablelistaa

@hoangdat hoangdat merged commit 440fe8f into main Jul 17, 2023
2 checks passed
@hoangdat hoangdat deleted the tw_268_create_private branch August 8, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants