Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-136: Change photo when create group #307

Merged
merged 9 commits into from
Jul 20, 2023
Merged

TW-136: Change photo when create group #307

merged 9 commits into from
Jul 20, 2023

Conversation

nqhhdev
Copy link
Member

@nqhhdev nqhhdev commented Jul 12, 2023 •
edited
Loading

  1. Delete text in app bar search when an item is selected successfully
Screen.Recording.2023-07-17.at.03.52.43.mov
  1. Add loading for floating action bottom
Screen.Recording.2023-07-14.at.14.25.13.mov
  1. Upload avatar failed => continue creating chat
Screen.Recording.2023-07-14.at.01.57.10.mov
  1. Uploaded avatar => created chat
Screen.Recording.2023-07-14.at.02.03.20.mov
  1. Cancel uploading avatar => continue creating chat
Screen.Recording.2023-07-14.at.02.30.58.mov

hoangdat
hoangdat reviewed Jul 12, 2023
View reviewed changes
lib/pages/new_group/new_group.dart Outdated Show resolved Hide resolved
lib/pages/new_group/new_group.dart Outdated Show resolved Hide resolved
lib/pages/new_group/new_group_chat_info.dart Outdated Show resolved Hide resolved
@sherlockvn
Copy link
Contributor

  1. Preview avatar and get uri when selected image

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-13.at.01.34.37.mp4

Should change the border radius of avatar shadow when user click to avatar

@nqhhdev nqhhdev changed the title [WIP] TW-136: Change photo when create group TW-136: Change photo when create group Jul 13, 2023
@nqhhdev nqhhdev force-pushed the TW-136-chang-photo-when-create-group branch from bd97f63 to 507e5a5 Compare July 13, 2023 19:42
hoangdat
hoangdat reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@hoangdat hoangdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite good for me 👍

lib/domain/app_state/room/upload_avatar_new_group_chat_state.dart Outdated Show resolved Hide resolved
lib/domain/usecase/room/upload_avatar_new_group_chat_interactor.dart Outdated Show resolved Hide resolved
@sherlockvn
Copy link
Contributor

  1. Delete text in app bar search when an item is selected successfully

Screen.Recording.2023-07-17.at.03.52.43.mov
2. Add loading for floating action bottom

Screen.Recording.2023-07-14.at.14.25.13.mov
3. Upload avatar failed => continue creating chat

Screen.Recording.2023-07-14.at.01.57.10.mov
3. Uploaded avatar => created chat

Screen.Recording.2023-07-14.at.02.03.20.mov
4. Cancel uploading avatar => continue creating chat

Screen.Recording.2023-07-14.at.02.30.58.mov

Avatar missing when click to fab button, i think it should not

@nqhhdev nqhhdev force-pushed the TW-136-chang-photo-when-create-group branch from 42a9151 to b76ae1d Compare July 17, 2023 15:36
@hoangdat
Copy link
Member

@nqhhdev Khải is trying to separate Image_picker_mixin, can we can reuse it?

@hoangdat
Copy link
Member

hoangdat commented Jul 19, 2023 •
edited
Loading

  • clear text and keep focus after search and select a contact
  • if empty group name: disable create button
  • group name input:
    • if members <= 3: pick display name: A, B and C and select all text, focus in here, show keyboard in mobile
    • else: group name empty

@nqhhdev nqhhdev force-pushed the TW-136-chang-photo-when-create-group branch from 16f7f36 to 6a86ba0 Compare July 19, 2023 08:04
@nqhhdev
Copy link
Member Author

nqhhdev commented Jul 19, 2023 •
edited
Loading

  • clear text and keep focus after search and select a contact

  • if empty group name: disable create button

  • group name input:

    • if members <= 3: pick display name: A, B and C and select all text, focus in here, show keyboard in mobile
    • else: group name empty

My demo

Screen.Recording.2023-07-19.at.15.09.33.mov
Screen.Recording.2023-07-19.at.15.21.00.mov

hoangdat
hoangdat reviewed Jul 19, 2023
View reviewed changes
lib/config/routes.dart Outdated Show resolved Hide resolved
lib/config/routes.dart Outdated Show resolved Hide resolved
sherlockvn
sherlockvn reviewed Jul 19, 2023
View reviewed changes
lib/pages/new_group/new_group.dart Outdated Show resolved Hide resolved
lib/pages/new_group/new_group.dart Outdated Show resolved Hide resolved
@nqhhdev nqhhdev force-pushed the TW-136-chang-photo-when-create-group branch from bec25e1 to 64c123c Compare July 19, 2023 13:15
hoangdat
hoangdat reviewed Jul 19, 2023
View reviewed changes
lib/config/routes.dart Outdated Show resolved Hide resolved
@nqhhdev nqhhdev force-pushed the TW-136-chang-photo-when-create-group branch from 64c123c to bbe711f Compare July 20, 2023 01:37
@nqhhdev nqhhdev force-pushed the TW-136-chang-photo-when-create-group branch from bbe711f to 0f2db98 Compare July 20, 2023 02:46
@hoangdat hoangdat merged commit 25ec758 into main Jul 20, 2023
2 checks passed
@hoangdat hoangdat deleted the TW-136-chang-photo-when-create-group branch August 8, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherlockvn sherlockvn sherlockvn left review comments

@imGok imGok imGok left review comments

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nqhhdev @sherlockvn @hoangdat @imGok