New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tw 403/share files by twake #526

Merged

hoangdat merged 2 commits into main from TW-403/share-files-by-twake

Aug 30, 2023

Contributor

sherlockvn commented Aug 25, 2023 •

edited

Loading

Done work:

Refactor Forward screen, chat list
Navigate to Share screen
use component in Forward screen to build Share screen

Demo ios:

https://photos.app.goo.gl/7VrGnpkn6C2oqTtx7

Demo Android:

Screen.Recording.2023-08-29.at.13.51.41.mov

sherlockvn requested review from hoangdat, dab246, nqhhdev, imGok and drminh2807 as code owners

August 25, 2023 10:57

sherlockvn force-pushed the TW-403/share-files-by-twake branch from 576ed5d to 58a55c7 Compare

August 27, 2023 17:43

Member

nqhhdev commented Aug 27, 2023

It's support for web right? Pls add small demo

nqhhdev reviewed

View reviewed changes

lib/pages/share/share_view.dart Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/share/share_view.dart Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/selectable_chat_list_item.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/selectable_chat_list_item.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/selectable_chat_list_item.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/recent_chat_list.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/forward_view.dart Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/forward.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/chat/chat.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/chat_list/chat_list.dart Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/chat_list/receive_sharing_intent_mixin.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/chat_list/chat_list_item.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/share/share.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/forward_item_style.dart Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/forward_view.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/forward/forward_view.dart Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/share/share_view.dart Outdated Show resolved Hide resolved

sherlockvn force-pushed the TW-403/share-files-by-twake branch from 58a55c7 to 4f2f8de Compare

August 27, 2023 18:55

Contributor Author

sherlockvn commented Aug 28, 2023

It's support for web right? Pls add small demo

Not right now, my ticket focus on mobile: android and iOS

hoangdat reviewed

View reviewed changes

android/app/src/main/AndroidManifest.xml Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/config/go_routes/go_router.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/pages/chat_list/chat_list.dart Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/pages/chat_list/chat_list_header.dart Outdated Show resolved Hide resolved

hoangdat reviewed

View reviewed changes

lib/pages/chat_list/chat_list_header.dart Outdated Show resolved Hide resolved

sherlockvn temporarily deployed to PR-526

August 28, 2023 10:03

— with

GitHub Actions Inactive

github-actions bot commented Aug 28, 2023

This PR has been deployed to https://linagora.github.io/twake-on-matrix/526

sherlockvn temporarily deployed to PR-526

August 28, 2023 10:41

— with

GitHub Actions Inactive

hoangdat reviewed

View reviewed changes

pubspec.yaml

Comment on lines +80 to +83

+                receive_sharing_intent:
+                  git:
+                    url: git@github.com:krabbenprgr/receive_sharing_intent.git
+                    ref: receive-.txt-v2

Member

hoangdat Aug 28, 2023

why we need this?

Contributor Author

sherlockvn Aug 28, 2023

The package is not maintained by the author. In the repository, it has a lot of PRs pending and nice features, so this PRs allow share .txt files.

imGok reviewed

View reviewed changes

lib/pages/chat_list/chat_list_header.dart Outdated

+                              enabled: false,
+                              decoration: InputDecoration(
+                                filled: true,
+                                contentPadding: const EdgeInsets.all(0),

Contributor

imGok Aug 28, 2023

does it have the same effect ?
isCollapsed: true

Contributor Author

sherlockvn Aug 28, 2023 •

edited

Loading

i think its different. i will try it tomorrow.

drminh2807 reviewed

View reviewed changes

lib/pages/forward/recent_chat_title.dart Outdated Show resolved Hide resolved

drminh2807 reviewed

View reviewed changes

lib/pages/share/share.dart Show resolved Hide resolved

drminh2807 reviewed

View reviewed changes

lib/pages/share/share_view.dart

+                        return TwakeFloatingActionButton(
+                          icon: Icons.send,
+                          size: 18.0,
+                          onTap: () => controller.shareTo(

Contributor

drminh2807 Aug 29, 2023 •

edited

Loading

Suggested change

      
                        onTap: () => controller.shareTo(
          
                        onTap: () => controller.onSubmit(context),

view should pass view params only, controller knows it's params itself

Contributor

drminh2807 Aug 29, 2023

still not fixed

sherlockvn temporarily deployed to PR-526

August 29, 2023 03:48

— with

GitHub Actions Inactive

sherlockvn temporarily deployed to PR-526

August 29, 2023 06:43

— with

GitHub Actions Inactive

sherlockvn temporarily deployed to PR-526

August 29, 2023 07:22

— with

GitHub Actions Inactive

nqhhdev reviewed

View reviewed changes

lib/config/go_routes/go_router.dart Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/chat/chat.dart Show resolved Hide resolved

drminh2807 reviewed

View reviewed changes

lib/pages/forward/forward_view.dart Outdated

-                      valueListenable: widget.controller.forwardMessageNotifier,
-                      builder: (context, forwardMessageNotifier, child) {
-                        if (forwardMessageNotifier == null) {
+              class ForwardButton extends StatelessWidget {

Contributor

drminh2807 Aug 29, 2023

Suggested change

      
            class ForwardButton extends StatelessWidget {
          
            class _ForwardButton extends StatelessWidget {

drminh2807 reviewed

View reviewed changes

lib/pages/forward/forward_view.dart Outdated Show resolved Hide resolved

nqhhdev reviewed

View reviewed changes

lib/pages/chat_list/chat_list_item.dart Outdated Show resolved Hide resolved

drminh2807 reviewed

View reviewed changes

lib/pages/chat/chat.dart Outdated Show resolved Hide resolved

sherlockvn temporarily deployed to PR-526

August 29, 2023 08:26

— with

GitHub Actions Inactive

sherlockvn added 2 commits

August 29, 2023 19:15


          TW-403: refactor forward and chat list controller and view

d072481


          TW-403: add share screen and share intent

sherlockvn force-pushed the TW-403/share-files-by-twake branch from dc23b7d to 7822458 Compare

August 29, 2023 12:16

sherlockvn temporarily deployed to PR-526

August 29, 2023 12:16

— with

GitHub Actions Inactive

hoangdat approved these changes

View reviewed changes

hoangdat merged commit 712f0d8 into main

3 checks passed

hoangdat deleted the TW-403/share-files-by-twake branch

September 25, 2023 10:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

drminh2807 drminh2807 left review comments

imGok imGok left review comments

nqhhdev nqhhdev left review comments

hoangdat hoangdat approved these changes

dab246 Awaiting requested review from dab246 dab246 is a code owner

Labels

None yet