-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tw 403/share files by twake #526
Conversation
576ed5d
to
58a55c7
Compare
It's support for web right? Pls add small demo |
58a55c7
to
4f2f8de
Compare
Not right now, my ticket focus on mobile: android and iOS |
This PR has been deployed to https://linagora.github.io/twake-on-matrix/526 |
receive_sharing_intent: | ||
git: | ||
url: git@github.com:krabbenprgr/receive_sharing_intent.git | ||
ref: receive-.txt-v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package is not maintained by the author. In the repository, it has a lot of PRs pending and nice features, so this PRs allow share .txt files.
enabled: false, | ||
decoration: InputDecoration( | ||
filled: true, | ||
contentPadding: const EdgeInsets.all(0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it have the same effect ?
isCollapsed: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its different. i will try it tomorrow.
return TwakeFloatingActionButton( | ||
icon: Icons.send, | ||
size: 18.0, | ||
onTap: () => controller.shareTo( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onTap: () => controller.shareTo( | |
onTap: () => controller.onSubmit(context), |
view should pass view params only, controller knows it's params itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still not fixed
lib/pages/forward/forward_view.dart
Outdated
valueListenable: widget.controller.forwardMessageNotifier, | ||
builder: (context, forwardMessageNotifier, child) { | ||
if (forwardMessageNotifier == null) { | ||
class ForwardButton extends StatelessWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class ForwardButton extends StatelessWidget { | |
class _ForwardButton extends StatelessWidget { |
dc23b7d
to
7822458
Compare
Done work:
Demo ios:
https://photos.app.goo.gl/7VrGnpkn6C2oqTtx7
Demo Android:
Screen.Recording.2023-08-29.at.13.51.41.mov