TW-492: Forward still ins tack after forward #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
sherlockvn,
hoangdat,
dab246,
imGok and
drminh2807
as code owners
|
You should add before and after demo, so we can understand the issue better |
sherlockvn
reviewed
Aug 28, 2023
lib/pages/chat/chat.dart
Outdated
| @@ -1287,3 +1293,8 @@ class ChatController extends State<Chat> | |||
| } | |||
|
|
|||
| enum EmojiPickerType { reaction, keyboard } | |||
|
|
|||
| class FowardAgr { | |||
There was a problem hiding this comment.
we have copilot and autocomplete please use the full name :))
lib/config/go_routes/go_router.dart
Outdated
Comment on lines
222
to
225
| if (state.extra is! ForwardArgument) { | ||
| return '${state.fullPath?.replaceAll('forward', '')}'; | ||
| } else { | ||
| return '/rooms/forward'; | ||
| } | ||
| }, |
There was a problem hiding this comment.
Early return:
Suggested change
| if (state.extra is! ForwardArgument) { | |
| return '${state.fullPath?.replaceAll('forward', '')}'; | |
| } else { | |
| return '/rooms/forward'; | |
| } | |
| }, | |
| if (state.extra is! ForwardArgument) { | |
| return '${state.fullPath?.replaceAll('forward', '')}'; | |
| } | |
| return '/rooms/forward'; | |
| } | |
| }, |
drminh2807
approved these changes
Aug 28, 2023
hoangdat
approved these changes
Aug 28, 2023
nqhhdev
force-pushed
the
TW-492-forward-still-ins-tack-after-forward
branch
from
995a0b1
to
8f37ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-08-28.at.11.20.25.mov
Web
Screen.Recording.2023-08-26.at.13.20.46.mov
Android
Screen.Recording.2023-08-26.at.13.29.35.mov