-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-492: Forward still ins tack after forward #527
Conversation
You should add before and after demo, so we can understand the issue better |
lib/pages/chat/chat.dart
Outdated
@@ -1287,3 +1293,8 @@ class ChatController extends State<Chat> | |||
} | |||
|
|||
enum EmojiPickerType { reaction, keyboard } | |||
|
|||
class FowardAgr { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have copilot
and autocomplete
please use the full name :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it
lib/config/go_routes/go_router.dart
Outdated
if (state.extra is! ForwardArgument) { | ||
return '${state.fullPath?.replaceAll('forward', '')}'; | ||
} else { | ||
return '/rooms/forward'; | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early return:
if (state.extra is! ForwardArgument) { | |
return '${state.fullPath?.replaceAll('forward', '')}'; | |
} else { | |
return '/rooms/forward'; | |
} | |
}, | |
if (state.extra is! ForwardArgument) { | |
return '${state.fullPath?.replaceAll('forward', '')}'; | |
} | |
return '/rooms/forward'; | |
} | |
}, |
995a0b1
to
8f37ab6
Compare
Screen.Recording.2023-08-28.at.11.20.25.mov
Web
Screen.Recording.2023-08-26.at.13.20.46.mov
Android
Screen.Recording.2023-08-26.at.13.29.35.mov