Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-492: Forward still ins tack after forward #527

Merged
merged 2 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/config/go_routes/go_router.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import 'package:fluffychat/pages/chat_draft/draft_chat.dart';
import 'package:fluffychat/pages/chat_encryption_settings/chat_encryption_settings.dart';
import 'package:fluffychat/pages/homeserver_picker/homeserver_picker.dart';
import 'package:fluffychat/pages/story/story_page.dart';
import 'package:fluffychat/presentation/model/forward/forward_argument.dart';
import 'package:fluffychat/utils/responsive/responsive_utils.dart';
import 'package:fluffychat/widgets/layouts/adaptive_layout/adaptive_scaffold.dart';
import 'package:fluffychat/widgets/layouts/adaptive_layout/adaptive_scaffold_route.dart';
Expand Down Expand Up @@ -217,11 +218,16 @@ abstract class AppRoutes {
),
GoRoute(
path: 'forward',
redirect: (context, state) {
if (state.extra is ForwardArgument) return '/rooms/forward';

return '${state.fullPath?.replaceAll('forward', '')}';
},
pageBuilder: (context, state) {
final extra = state.extra as String?;
final extra = state.extra as ForwardArgument;
return defaultPageBuilder(
context,
Forward(sendFromRoomId: extra ?? ''),
Forward(sendFromRoomId: extra.fromRoomId),
);
},
),
Expand Down
8 changes: 7 additions & 1 deletion lib/pages/chat/chat.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import 'package:fluffychat/pages/chat/recording_dialog.dart';
import 'package:fluffychat/presentation/mixins/common_media_picker_mixin.dart';
import 'package:fluffychat/presentation/mixins/media_picker_mixin.dart';
import 'package:fluffychat/presentation/mixins/send_files_mixin.dart';
import 'package:fluffychat/presentation/model/forward/forward_argument.dart';
import 'package:fluffychat/utils/adaptive_bottom_sheet.dart';
import 'package:fluffychat/utils/matrix_sdk_extensions/ios_badge_client_extension.dart';
import 'package:fluffychat/utils/matrix_sdk_extensions/matrix_locals.dart';
Expand Down Expand Up @@ -824,7 +825,12 @@ class ChatController extends State<Chat>
);
}
setState(() => selectedEvents.clear());
context.go('/rooms/forward', extra: roomId);
context.go(
'/rooms/forward',
extra: ForwardArgument(
fromRoomId: roomId ?? '',
),
);
}

void sendAgainAction() {
Expand Down
2 changes: 1 addition & 1 deletion lib/pages/forward/forward.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class ForwardController extends State<Forward> {

Timeline? timeline;

String? get roomId => GoRouterState.of(context).pathParameters['roomid'];
String? get roomId => widget.sendFromRoomId;

final AutoScrollController forwardListController = AutoScrollController();

Expand Down
12 changes: 12 additions & 0 deletions lib/presentation/model/forward/forward_argument.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import 'package:fluffychat/config/go_routes/router_arguments.dart';

class ForwardArgument extends RouterArguments {
final String fromRoomId;

ForwardArgument({
required this.fromRoomId,
});

@override
List<Object?> get props => [fromRoomId];
}
6 changes: 4 additions & 2 deletions lib/widgets/fluffy_chat_app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ class FluffyChatApp extends StatefulWidget {

// Router must be outside of build method so that hot reload does not reset
// the current path.
static final GoRouter router =
GoRouter(routes: AppRoutes.routes, debugLogDiagnostics: true);
static final GoRouter router = GoRouter(
routes: AppRoutes.routes,
debugLogDiagnostics: true,
);

@override
FluffyChatAppState createState() => FluffyChatAppState();
Expand Down