Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-548 : add notifications bubble to navigation chat icon #553

Merged
merged 2 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/widgets/layouts/adaptive_layout/adaptive_scaffold_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ import 'package:fluffychat/di/global/get_it_initializer.dart';
import 'package:fluffychat/pages/chat_list/chat_list.dart';
import 'package:fluffychat/pages/contacts_tab/contacts_tab.dart';
import 'package:fluffychat/pages/search/search.dart';
import 'package:fluffychat/utils/matrix_sdk_extensions/client_stories_extension.dart';
import 'package:fluffychat/utils/responsive/responsive_utils.dart';
import 'package:fluffychat/widgets/layouts/adaptive_layout/adaptive_scaffold_primary_navigation.dart';
import 'package:fluffychat/widgets/layouts/adaptive_layout/adaptive_scaffold.dart';
import 'package:fluffychat/widgets/layouts/enum/adaptive_destinations_enum.dart';
import 'package:fluffychat/widgets/twake_components/twake_navigation_icon/twake_navigation_icon.dart';
import 'package:fluffychat/widgets/unread_rooms_badge.dart';
import 'package:flutter/material.dart';
import 'package:flutter_adaptive_scaffold/flutter_adaptive_scaffold.dart';
import 'package:flutter_gen/gen_l10n/l10n.dart';
Expand Down Expand Up @@ -188,15 +191,21 @@ class AppScaffoldView extends StatelessWidget {
List<NavigationDestination> getNavigationDestinations(BuildContext context) {
return [
NavigationDestination(
icon: const Icon(Icons.contacts_outlined),
icon: const TwakeNavigationIcon(
icon: Icons.contacts_outlined,
),
label: L10n.of(context)!.contacts,
),
NavigationDestination(
icon: const Icon(Icons.chat),
icon: UnreadRoomsBadge(
filter: (room) => !room.isSpace && !room.isStoryRoom,
),
label: L10n.of(context)!.chat,
),
NavigationDestination(
icon: const Icon(Icons.web_stories_outlined),
icon: const TwakeNavigationIcon(
icon: Icons.web_stories_outlined,
),
label: L10n.of(context)!.stories,
),
];
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import 'package:fluffychat/widgets/twake_components/twake_navigation_icon/twake_navigation_icon_style.dart';
import 'package:flutter/material.dart';

class TwakeNavigationIcon extends StatelessWidget {
final IconData icon;
final int notificationCount;

const TwakeNavigationIcon({
super.key,
required this.icon,
this.notificationCount = 0,
});

@override
Widget build(BuildContext context) {
return Badge(
backgroundColor: Theme.of(context).colorScheme.error,
isLabelVisible: notificationCount > 0,
largeSize: TwakeNavigationIconStyle.badgeHeight,
label: Text(
notificationCount.toString(),
style: Theme.of(context).textTheme.labelSmall?.copyWith(
color: Theme.of(context).colorScheme.onError,
nqhhdev marked this conversation as resolved.
Show resolved Hide resolved
),
),
child: Icon(
icon,
color: Theme.of(context).colorScheme.onSurfaceVariant,
nqhhdev marked this conversation as resolved.
Show resolved Hide resolved
),
);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
class TwakeNavigationIconStyle {
static double get badgeHeight => 16.0;
}
28 changes: 4 additions & 24 deletions lib/widgets/unread_rooms_badge.dart
Original file line number Diff line number Diff line change
@@ -1,21 +1,17 @@
import 'package:collection/collection.dart';
import 'package:fluffychat/widgets/twake_components/twake_navigation_icon/twake_navigation_icon.dart';
import 'package:flutter/material.dart';

import 'package:badges/badges.dart' as b;
import 'package:matrix/matrix.dart';

import 'matrix.dart';

class UnreadRoomsBadge extends StatelessWidget {
final bool Function(Room) filter;
final b.BadgePosition? badgePosition;
final Widget? child;

const UnreadRoomsBadge({
Key? key,
required this.filter,
this.badgePosition,
this.child,
}) : super(key: key);

@override
Expand All @@ -29,25 +25,9 @@ class UnreadRoomsBadge extends StatelessWidget {
builder: (context, _) {
final unreadCount = getNotificationsCount(context);

return b.Badge(
alignment: Alignment.bottomRight,
badgeContent: Text(
unreadCount.toString(),
style: TextStyle(
color: Theme.of(context).colorScheme.onPrimary,
fontSize: 12,
),
),
showBadge: unreadCount != 0,
animationType: b.BadgeAnimationType.scale,
badgeColor: Theme.of(context).colorScheme.primary,
position: badgePosition,
elevation: 4,
borderSide: BorderSide(
color: Theme.of(context).colorScheme.background,
width: 2,
),
child: child,
return TwakeNavigationIcon(
icon: Icons.chat,
notificationCount: unreadCount,
);
},
);
Expand Down
8 changes: 0 additions & 8 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,6 @@ packages:
url: "https://pub.dev"
source: hosted
version: "3.0.0"
badges:
dependency: "direct main"
description:
name: badges
sha256: "727580d938b7a1ff47ea42df730d581415606b4224cfa708671c10287f8d3fe6"
url: "https://pub.dev"
source: hosted
version: "2.0.3"
base58check:
dependency: transitive
description:
Expand Down
1 change: 0 additions & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ dependencies:
adaptive_dialog: ^1.8.0+1
flutter_adaptive_scaffold: ^0.1.4
animations: ^2.0.7
badges: ^2.0.3
hoangdat marked this conversation as resolved.
Show resolved Hide resolved
blurhash_dart: ^1.1.0
callkeep: ^0.3.2
chewie: ^1.3.6
Expand Down