Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NestedDtype.construct_from_string to raise TypeError #23

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Apr 10, 2024

Previously it was ValueError which is inconsistent with the behavior expected by pandas.

Fixes #22

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Previously it was ValueError which is inconsistent with the behavior
expected by pandas.

Fixes #22
@hombit hombit requested a review from dougbrn April 10, 2024 14:20
Copy link

github-actions bot commented Apr 10, 2024

Before [136f2c5] After [5a82070] Ratio Benchmark (Parameter)
1.34±1s 1.82±1s ~1.36 benchmarks.time_computation
992 192 0.19 benchmarks.mem_list

Click here to view all benchmarks.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.14%. Comparing base (136f2c5) to head (7735901).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   92.93%   94.14%   +1.21%     
==========================================
  Files          13       13              
  Lines         566      564       -2     
==========================================
+ Hits          526      531       +5     
+ Misses         40       33       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit changed the title Change NestedDtype.from_string to raise TypeError Change NestedDtype.construct_from_string to raise TypeError Apr 10, 2024
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hombit hombit merged commit b822a14 into main Apr 10, 2024
11 checks passed
@hombit hombit deleted the fix-to_flat branch April 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dtype bug when attempting to use dropna on a flat representation
2 participants