Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement count_nested #28

Merged
merged 2 commits into from
Apr 12, 2024
Merged

implement count_nested #28

merged 2 commits into from
Apr 12, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Apr 12, 2024

Change Description

Solution Description

This PR implements the count_nested utility function, which is a generalization of the original calc_nobs idea.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (d63cee9) to head (c073b2e).

❗ Current head c073b2e differs from pull request most recent head 48c83de. Consider uploading reports for the commit 48c83de to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   94.92%   95.03%   +0.10%     
==========================================
  Files          13       15       +2     
  Lines         611      624      +13     
==========================================
+ Hits          580      593      +13     
  Misses         31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review April 12, 2024 18:08
Copy link

github-actions bot commented Apr 12, 2024

Before [d63cee9] After [55074fe] Ratio Benchmark (Parameter)
2.60±0.9s 1.41±0.8s ~0.54 benchmarks.time_computation
1.85k 3.45k 1.87 benchmarks.mem_list

Click here to view all benchmarks.

@dougbrn dougbrn requested a review from hombit April 12, 2024 18:09
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

src/nested_pandas/utils/utils.py Outdated Show resolved Hide resolved
@dougbrn dougbrn merged commit 39acb91 into main Apr 12, 2024
9 checks passed
@dougbrn dougbrn deleted the count_nested branch April 12, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVP: Implement the calc_nobs utility function
2 participants