Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .nest.to_flat / to_lists #90

Merged
merged 3 commits into from
May 28, 2024
Merged

Fix .nest.to_flat / to_lists #90

merged 3 commits into from
May 28, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented May 28, 2024

Fixes #89

The code example from #89 works now, but I'm not sure if I should add it as a test because of the Epyc server usage.

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit requested a review from dougbrn May 28, 2024 21:42
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (8197907) to head (ebcc24b).
Report is 76 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   98.68%   98.71%   +0.03%     
==========================================
  Files          15       15              
  Lines         836      859      +23     
==========================================
+ Hits          825      848      +23     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 28, 2024

Before [8197907] After [c8e774b] Ratio Benchmark (Parameter)
5.29±0.05ms 5.37±0.07ms 1.01 benchmarks.NestedFrameReduce.time_run
267M 270M 1.01 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
86.4M 86.6M 1 benchmarks.NestedFrameAddNested.peakmem_run
9.03±0.2ms 9.04±0.2ms 1 benchmarks.NestedFrameAddNested.time_run
89.6M 89.3M 1 benchmarks.NestedFrameQuery.peakmem_run
89.6M 89.3M 1 benchmarks.NestedFrameReduce.peakmem_run
257M 255M 0.99 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
6.43±0.03ms 6.22±0.08ms 0.97 benchmarks.NestedFrameQuery.time_run
33.1±2ms 31.3±2ms 0.95 benchmarks.AssignSingleDfToNestedSeries.time_run
59.2±2ms 54.4±4ms 0.92 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hombit hombit merged commit 41cce93 into main May 28, 2024
11 checks passed
@hombit hombit deleted the fix/issue/89 branch May 28, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Struct_array casting sometimes produces a ChunkedArray
2 participants