Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ext_array._pa_array to _chunked_array #94

Merged
merged 2 commits into from
May 29, 2024
Merged

Rename ext_array._pa_array to _chunked_array #94

merged 2 commits into from
May 29, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented May 29, 2024

pandas' ArrowExtensionArray uses ._pa_array for the underlying array data, but it is a bit confusing because it is actually a chunked array. This PR changes this name in our implementation and also introduces a public chunked_array property.

It adds a data model description to NestedExtensionArray docs.

@hombit hombit requested a review from dougbrn May 29, 2024 21:41
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (0ed3746) to head (d193826).
Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files          15       15           
  Lines         890      893    +3     
=======================================
+ Hits          879      882    +3     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [0ed3746] After [c7fd4f3] Ratio Benchmark (Parameter)
54.9±2ms 57.0±2ms 1.04 benchmarks.ReassignHalfOfNestedSeries.time_run
5.13±0.05ms 5.22±0.3ms 1.02 benchmarks.NestedFrameReduce.time_run
257M 260M 1.01 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
270M 273M 1.01 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
86.5M 86.5M 1 benchmarks.NestedFrameAddNested.peakmem_run
8.73±0.08ms 8.74±0.08ms 1 benchmarks.NestedFrameAddNested.time_run
90.1M 89.7M 1 benchmarks.NestedFrameQuery.peakmem_run
6.13±0.03ms 6.12±0.03ms 1 benchmarks.NestedFrameQuery.time_run
89.4M 89.7M 1 benchmarks.NestedFrameReduce.peakmem_run
32.1±1ms 31.1±1ms 0.97 benchmarks.AssignSingleDfToNestedSeries.time_run

Click here to view all benchmarks.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good

@hombit hombit merged commit f861313 into main May 29, 2024
11 checks passed
@hombit hombit deleted the chunked_array branch May 29, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants