Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for client sharing between Ensembles #362

Open
dougbrn opened this issue Jan 31, 2024 · 1 comment
Open

Improve support for client sharing between Ensembles #362

dougbrn opened this issue Jan 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dougbrn
Copy link
Collaborator

dougbrn commented Jan 31, 2024

Currently, the Ensemble has functionality to close a tied client during ending operations like exit and del. This is governed by the Ensemble.cleanup_client variable that is set when a client is tied to the Ensemble. This complicates the ability for multiple ensembles to share a given client, as one may attempt to close the client that is still in use by another ensemble. We should implement a more robust relationship between an ensemble and a client, such that multiple clients can use an ensemble without pre-emptive attempts to close it, but also eventually closing it when no Ensembles are left using it.

@dougbrn dougbrn added the enhancement New feature or request label Jan 31, 2024
@wilsonbb
Copy link
Collaborator

Note that issues related to client sharing were observed in the flaky test failures in issue #328

Most of those failures were resolved by having mostly clientless unit tests (#376), but those failures are good examples of the kind of shared client issues we want to improve upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants