.github: Migrate to the pyproject.toml #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
changed the title
|
@darjeeling will handle to support uv with future PR. |
|
@hexoul Ready to get review :) |
corona10
changed the title
corona10
commented
Nov 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
===========================================
+ Coverage 81.30% 93.41% +12.11%
===========================================
Files 23 24 +1
Lines 706 714 +8
===========================================
+ Hits 574 667 +93
+ Misses 132 47 -85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I agree with this PR |
Co-authored-by: Seunggon Kim <crosien@gmail.com>
Co-authored-by: Seunggon Kim <crosien@gmail.com>
|
@hexoul Done except the comment I leave: https://github.com/line/centraldogma-python/pull/56/files#r1828632599 |
hexoul
reviewed
Nov 5, 2024
ikhoon
reviewed
Nov 5, 2024
.github/workflows/test.yml
Outdated
| @@ -11,10 +11,18 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: ammaraskar/sphinx-action@master | |||
| - name: Set up Python ${{ matrix.python-version }} | |||
There was a problem hiding this comment.
matrix.python-version seems not available in docs job.
There was a problem hiding this comment.
Ah thank you for catching.
hexoul
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python community are now dropping the requirements.txt based project and moving to use pyproject.toml instead.
See: https://peps.python.org/pep-0518/
For this change, we need to drop supporting Python 3.8 but it will be okay since we already decided to drop supporting Python 3.8 at #54