Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use package name for link type notation #32

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

r-ralph
Copy link
Member

@r-ralph r-ralph commented Nov 20, 2023

Flags that exist in other modules can be linked by module-name:flag-name, and for this purpose, there is logic to get the package name from the module name.
It uses Task.getProject(), but it'll be deprecated (only for task phase) and it cannot be used from Gradle 9.0.
Therefore, to avoid having to subtract the package name from the module name, the specification of the link notation should be changed so that the package name is directly described.

Breaking Changes

Link type notation is changed as following:

AS-IS

module-name:flag_name

TO-BE

package.name:flag_name

@r-ralph r-ralph changed the title Change link type notation spec Change to use package name for link type notation Nov 20, 2023
Copy link
Contributor

@ganadist ganadist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r-ralph r-ralph merged commit 43e427d into line:master Nov 20, 2023
2 checks passed
@r-ralph r-ralph deleted the link-spec-change branch November 20, 2023 05:37
@r-ralph r-ralph added this to the 3.0.0 milestone Nov 20, 2023
@r-ralph r-ralph self-assigned this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants