Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Downs and Tooltips don't take Window Insets into account #2307

Open
CryZe opened this issue Dec 16, 2022 · 1 comment
Open

Drop Downs and Tooltips don't take Window Insets into account #2307

CryZe opened this issue Dec 16, 2022 · 1 comment
Labels
bug does not behave the way it is supposed to shell/win concerns the Windows backend

Comments

@CryZe
Copy link
Contributor

CryZe commented Dec 16, 2022

This one is a trivial problem to fix, I'll probably send a PR later. On at least Windows they are spawned in coordinates relative to the top left of the window, but they accidentally use the outer top left instead of the inner top left. Other operating systems may be affected too.

@xStrom xStrom added the bug does not behave the way it is supposed to label Dec 17, 2022
@xStrom
Copy link
Member

xStrom commented Jan 9, 2023

I think this comes from window inset treatment itself being broken on Windows. When you create a window in Druid and specify a size, that size is supposed to represent the size of the content. On the Windows platform this is not the case right now, instead it represents an imaginery size (not even just content+borders .. it also has +transparent_padding for compatibility reasons or something).

What we need is a comprehensive fix of the window sizing code in druid-shell Windows backend, so that it matches the other backends. I have some preliminary plans of fixing this in glazier and when that fix lands we can see how easy it is to backport it to druid-shell. Of course if anyone else feels like doing some fixes before me, that's fine too.

@xStrom xStrom added the shell/win concerns the Windows backend label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug does not behave the way it is supposed to shell/win concerns the Windows backend
Projects
None yet
Development

No branches or pull requests

2 participants