Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial tryout of PaginatedResponse #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dennisdegreef
Copy link
Contributor

@dennisdegreef dennisdegreef commented Mar 13, 2017

Currently there is no functionality to make use of the pagination in responses.
This pull request attempts to fix this, by using PHP's generators to only do the API call when traversed.

The only problem is that when you'd also want to use \ArrayAccess it shows weird behaviour if implemented.

var_dump(isset($response[30])); // false
foreach ($response as $value) {}
var_dump(isset($response[30])); // true

Note that since the items are added after first recursion traversal, it also acts as a cache, and enabled the array access after traversal up until item X using a for-loop, or up until the last item when using while/foreach.

Any feedback on this implementation is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant