Add error threshold and verify domain name for instance in helix tool #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2525 +/- ##
=============================================
- Coverage 72.88% 33.47% -39.41%
+ Complexity 11237 4999 -6238
=============================================
Files 792 792
Lines 63701 63714 +13
Branches 7788 7790 +2
=============================================
- Hits 46426 21331 -25095
- Misses 14725 40705 +25980
+ Partials 2550 1678 -872
☔ View full report in Codecov by Sentry. |
ambry-clustermap/src/main/java/com/github/ambry/clustermap/HelixBootstrapUpgradeUtil.java
Show resolved
Hide resolved
| new HelixConfigScope(HelixConfigScope.ConfigScopeProperty.PARTICIPANT, Collections.singletonList(clusterName), | ||
| null); | ||
| // This will list all the participant names | ||
| List<String> instanceNames = configAccessor.getKeys(scope); |
There was a problem hiding this comment.
Hmm, when --resources input is given to this tool, I think I called setInstanceConfig only for the instances hosting partitions of those resources (line number 894). But, configAccessor.getKeys(scope) may get all instances in the cluster. May be we need to set DOMAIN field for all instances in the cluster (irrespective of inputted resources) now ?
There was a problem hiding this comment.
we should probably do that, let me update it.
justinlin-linkedin
force-pushed
the
justin/helixupgradetool
branch
from
26c957e
to
54343ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes