-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update full-auto migration tool #2529
Update full-auto migration tool #2529
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2529 +/- ##
=============================================
- Coverage 32.40% 19.52% -12.89%
+ Complexity 4460 2787 -1673
=============================================
Files 806 806
Lines 65491 65599 +108
Branches 7994 8015 +21
=============================================
- Hits 21225 12809 -8416
- Misses 42031 51609 +9578
+ Partials 2235 1181 -1054 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, can you please add another command to switch FULLAUTO back to SEMI AUTO.
// 3. Set semi-auto placement as preference list so that no replicas are moved. | ||
Map<String, List<String>> semiAutoPreferenceLists = idealState.getPreferenceLists(); | ||
resourceConfig.setPreferenceLists(semiAutoPreferenceLists); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have another parameter to control this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Sure. Added command to switch back to SEMI AUTO |
8745663
to
4ed5603
Compare
2.Add option to populate semi-auto placement as preference lists during Full-Auto migration 3.Add option to roll back to semi auto 4.Add changes to add configs only without enabling Full Auto 5.Add changes for migrating video cluster
ffc70e7
to
7c37037
Compare
/export/apps/jdk/JDK-1_8_0_121/bin/java -Dlog4j2.configurationFile=file:./log4j2.xml -cp ambry.jar com.github.ambry.clustermap.HelixBootstrapUpgradeTool --clusterName Ambry-EI --dcs ei-ltx1 --zkLayoutPath zkLayoutEI.json --resourceName 10001 --partitions 180,183,189,196,201 --updatePreferenceLists