Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default replica capacity in resource config #2531

Merged

Conversation

justinlin-linkedin
Copy link
Collaborator

Add default replicas capacity in resource config and use this replica capacity to create new partition

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Patch coverage: 70.96% and project coverage change: +0.02% 🎉

Comparison is base (827d592) 72.88% compared to head (d024e70) 72.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2531      +/-   ##
============================================
+ Coverage     72.88%   72.90%   +0.02%     
- Complexity    11237    11244       +7     
============================================
  Files           792      792              
  Lines         63701    63729      +28     
  Branches       7788     7794       +6     
============================================
+ Hits          46426    46461      +35     
+ Misses        14725    14721       -4     
+ Partials       2550     2547       -3     
Files Changed Coverage Δ
...a/com/github/ambry/clustermap/ClusterMapUtils.java 92.13% <ø> (+0.32%) ⬆️
...ub/ambry/clustermap/HelixBootstrapUpgradeUtil.java 70.46% <0.00%> (-0.15%) ⬇️
...m/github/ambry/clustermap/HelixClusterManager.java 89.29% <78.57%> (+1.27%) ⬆️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinlin-linkedin justinlin-linkedin changed the title WIP: Add default replica capacity in resource config Add default replica capacity in resource config Aug 8, 2023
Copy link
Contributor

@SophieGuo410 SophieGuo410 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justinlin-linkedin justinlin-linkedin merged commit 3f94e40 into linkedin:master Aug 9, 2023
5 checks passed
@justinlin-linkedin justinlin-linkedin deleted the justin/capacity branch August 9, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants