Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Named Blob] Filter out expired/deleted entries in listing named blob #2534

Merged

Conversation

mikeyang923
Copy link
Contributor

Filter out expired/deleted entries in listing named blob

Copy link
Collaborator

@justinlin-linkedin justinlin-linkedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test cases

@mikeyang923
Copy link
Contributor Author

Please add some test cases

Ok, just added. thanks!

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (827d592) 72.88% compared to head (5499e9d) 72.91%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2534      +/-   ##
============================================
+ Coverage     72.88%   72.91%   +0.02%     
- Complexity    11237    11242       +5     
============================================
  Files           792      792              
  Lines         63701    63726      +25     
  Branches       7788     7793       +5     
============================================
+ Hits          46426    46463      +37     
+ Misses        14725    14715      -10     
+ Partials       2550     2548       -2     
Files Changed Coverage Δ
.../java/com/github/ambry/named/MySqlNamedBlobDb.java 87.25% <100.00%> (+1.26%) ⬆️

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinlin-linkedin justinlin-linkedin merged commit 0f56175 into linkedin:master Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants