Pass in clean blob id into router.ttlUpdate #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlin-linkedin
approved these changes
Oct 4, 2024
SophieGuo410
pushed a commit
that referenced
this pull request
Oct 11, 2024
This reverts commit cb39e67.
SophieGuo410
added a commit
that referenced
this pull request
Oct 12, 2024
* Revert "Remove cluster name for blobId used in router (#2913)" This reverts commit ba36dd8. * Revert "Pass in clean blob id into router.ttlUpdate (#2912)" This reverts commit cb39e67. * Revert "Remove the size update for stitch request (#2904)" This reverts commit ad1cc58. * Revert "Move id converter inside of router phase4 (#2899)" This reverts commit 5399282. --------- Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz>
SophieGuo410
added a commit
that referenced
this pull request
Oct 12, 2024
Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz>
SophieGuo410
added a commit
that referenced
this pull request
Oct 30, 2024
* Move id converter inside of router phase4 (#2899) * Move id converter inside of router phase4 * Move ttl update inside of router for named blob put request * Address comments --------- Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz> * Remove the size update for stitch request (#2904) Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz> * Pass in clean blob id into router.ttlUpdate (#2912) Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz> * Remove cluster name for blobId used in router (#2913) * Remove cluster name for blobId used in router * Adding tests * Adding unit test --------- Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz> * Adding integration test for dataset * Remove test --------- Co-authored-by: Sophie Guo <sopguo@sopguo-mn2.linkedin.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.