Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concurrent skiplist map for NettyRequest arguments #2927

Merged

Conversation

justinlin-linkedin
Copy link
Collaborator

Summary

Map for header and query parameter in NettyRequest should be case-insensitive. Start using concurrent skiplist map with CASE_INSENSITIVE_ORDER from String.

Test

Added unit test

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (52ba813) to head (a5dba9c).
Report is 125 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2927      +/-   ##
============================================
+ Coverage     64.24%   70.37%   +6.12%     
- Complexity    10398    11980    +1582     
============================================
  Files           840      864      +24     
  Lines         71755    73672    +1917     
  Branches       8611     8866     +255     
============================================
+ Hits          46099    51843    +5744     
+ Misses        23004    19133    -3871     
- Partials       2652     2696      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinlin-linkedin justinlin-linkedin merged commit 94dec49 into linkedin:master Oct 24, 2024
5 checks passed
@justinlin-linkedin justinlin-linkedin deleted the justin/caseinsensitive branch October 24, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants