Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print out more message in AmbryNetworkRequestHandler #2936

Merged

Conversation

justinlin-linkedin
Copy link
Collaborator

Summary

Print out more message in exceptionCaught method in AmbryNetworkRequestHandler.

Test

Unit test

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (52ba813) to head (57d906f).
Report is 135 commits behind head on master.

Files with missing lines Patch % Lines
...mbry/network/http2/AmbryNetworkRequestHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2936      +/-   ##
============================================
+ Coverage     64.24%   70.20%   +5.96%     
- Complexity    10398    11971    +1573     
============================================
  Files           840      865      +25     
  Lines         71755    73668    +1913     
  Branches       8611     8863     +252     
============================================
+ Hits          46099    51720    +5621     
+ Misses        23004    19246    -3758     
- Partials       2652     2702      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinlin-linkedin justinlin-linkedin merged commit 9b4a1ac into linkedin:master Nov 8, 2024
5 checks passed
@justinlin-linkedin justinlin-linkedin deleted the justin/morelog branch November 8, 2024 20:57
alyssaxu333 pushed a commit that referenced this pull request Nov 15, 2024
Print out more message in exceptionCaught method in AmbryNetworkRequestHandler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants