[fast-avro] FastGenericDatumReader forwards setSchema() to coldDeserializer #534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in a comment:
Consider below code-snippet:
Writer schema passed to
FastSpecificDatumReader
's c-tor isnull
because it's unknown yet.C-tor of
DataFileStream
extracts the writerSchema frominputStream
and passes it to thedatumReader
by invokingreader.setSchema(header.schema);
This PR forwards
setSchema()
call tocoldDeserializer
which is used until the actual (fast) deserializer is generated.