Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming collectors for stable performance #536

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

karthikrg
Copy link
Contributor

Java parallelStream uses the default ForkJoinPool which is heavily used by gradle as well for internal tasks. Because the size of this pool is limited to maxProcessors - 1, performance is unpredictable depending on what else gradle is running.

To get around this, use a dedicated executor via a streaming collector.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88a00c1) 46.02% compared to head (1def7da) 46.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #536      +/-   ##
============================================
+ Coverage     46.02%   46.04%   +0.01%     
- Complexity     4489     4493       +4     
============================================
  Files           406      407       +1     
  Lines         28115    28120       +5     
  Branches       4622     4622              
============================================
+ Hits          12941    12947       +6     
  Misses        13627    13627              
+ Partials       1547     1546       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-ukumar li-ukumar merged commit 62510e8 into linkedin:master Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants