Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fast-avro][deserializer] Populate methods always with 'customization' argument #557

Merged
merged 2 commits into from
May 6, 2024
Merged

[fast-avro][deserializer] Populate methods always with 'customization' argument #557

merged 2 commits into from
May 6, 2024

Commits on May 6, 2024

  1. Populate methods now always have 'customization' parameter because 

    deserialize-method(s) of nested records may generate another
populate methods that require 'customization' (at least for compilation).

TDD approach - this commit adds unit test which fails and shows
where the issue actually is.
    @krisso-rtb
    krisso-rtb committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8ee90fe View commit details
    Browse the repository at this point in the history

  2. [fast-avro] Populate methods now always have 'customization' parameter 

    because deserialize-method(s) of nested records may generate another
populate methods that require 'customization' (at least for compilation).

This commits contains the fix.
    @krisso-rtb
    krisso-rtb committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ff2c378 View commit details
    Browse the repository at this point in the history