Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove-disks endpoint doesn't work when used with skip_hard_goal_check and verbose parameter #2105

Closed
ShubhamRwt opened this issue Jan 10, 2024 · 4 comments · May be fixed by #2106
Closed

Remove-disks endpoint doesn't work when used with skip_hard_goal_check and verbose parameter #2105

ShubhamRwt opened this issue Jan 10, 2024 · 4 comments · May be fixed by #2106

Comments

@ShubhamRwt
Copy link

ShubhamRwt commented Jan 10, 2024 •
edited
Loading

When we try to use the remove-disks endpoint and try to use a curl command with skip_hard_goal_check or verbose parameter

curl -vv -X POST "http://localhost:9090/kafkacruisecontrol/remove_disks?json=true&dryrun=true&verbose=false&skip_hard_goal_check=false&brokerid_and_logdirs=0-%2Fvar%2Flib%2Fkafka%2Fdata-0%2Fkafka-log0"

the endpoint doesn't work and return this error

{"version":1,"errorMessage":"Unrecognized endpoint parameters in REMOVE_DISKS POST request: [skip_hard_goal_check, verbose].","stackTrace":""}
@mhratson
Copy link
Contributor

What's the behaviour you're expecting?

The error shows those are unsupported parameters

@ShubhamRwt
Copy link
Author

@mhratson Hi, I was expecting that if it doesn't support those parameter then instead of giving error shouldn't it just ignore it? Also shouldn't it be fine to support parameters like verbose?

@mhratson
Copy link
Contributor

giving error shouldn't it just ignore it?

Evidently it's not the current behavior.

Also shouldn't it be fine to support parameters like verbose?

PRs are welcomed :)

@ShubhamRwt
Copy link
Author

Thanks, I will create one

@ShubhamRwt ShubhamRwt mentioned this issue Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add verbose parameter to remove-disks endpoint valid parameter list ShubhamRwt/cruise-control-1
2 participants
@mhratson @ShubhamRwt