Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent entry.time across browsers #104

Open
satyamk7054 opened this issue Jan 28, 2019 · 1 comment
Open

Inconsistent entry.time across browsers #104

satyamk7054 opened this issue Jan 28, 2019 · 1 comment

Comments

@satyamk7054
Copy link

Spaniel's polyfill for IntersectionObserver uses Date.now() for setting entry.time, which is relative to epoch. The native implementation defines entry.time as being relative to the creation of the document (ref: https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserverEntry/time).

@lynchbomb
Copy link
Member

lynchbomb commented Jan 28, 2019

@satyamk7054 thank you for raising this to our attention. @asakusuma and I have chatted concerning and the current plan is to implement this fix forward within a new spaniel release (v5.x.x) as this will be a breaking change.

If you have cycles to work on this, a PR would be more than welcome :) Otherwise we will queue the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants