[vpj][all] Create a new module for offline components to reduce leakage

linkedin · Sep 28, 2024 · 6b24eac · 6b24eac
1 parent 939d655
commit 6b24eac
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 6 deletions.
diff --git a/clients/venice-push-job/build.gradle b/clients/venice-push-job/build.gradle
@@ -8,6 +8,8 @@ dependencies {
     exclude module: ':internal:alpini'
   }
 
+  implementation project(':internal:venice-hadoop-common')
+
   implementation (libraries.avro) {
     exclude group: 'org.mortbay.jetty' // jetty 6 conflicts with spark-java used in controller api
   }

diff --git a/internal/venice-common/build.gradle b/internal/venice-common/build.gradle
@@ -30,12 +30,6 @@ dependencies {
     exclude group: 'com.linkedin.container', module: 'container-eventbus-factory' // Keeping' it clean.
   }
 
-  implementation (libraries.hadoopCommon) {
-    // Exclude transitive dependency
-    exclude group: 'org.apache.avro'
-    exclude group: 'javax.servlet'
-  }
-
   implementation project(':clients:venice-thin-client')
 
   implementation libraries.avroUtilCompatHelper

diff --git a/internal/venice-hadoop-common/build.gradle b/internal/venice-hadoop-common/build.gradle
@@ -0,0 +1,12 @@
+dependencies {
+    implementation project(':internal:venice-common')
+    implementation libraries.log4j2api
+    implementation (libraries.hadoopCommon) {
+        // Exclude transitive dependency
+        exclude group: 'org.apache.avro'
+        exclude group: 'javax.servlet'
+    }
+
+    testImplementation platform('org.junit:junit-bom:5.9.1')
+    testImplementation 'org.junit.jupiter:junit-jupiter'
+}
diff --git a/...enice/hadoop/schema/HDFSSchemaSource.java → ...enice/hadoop/schema/HDFSSchemaSource.java b/...enice/hadoop/schema/HDFSSchemaSource.java → ...enice/hadoop/schema/HDFSSchemaSource.java
diff --git a/...in/venice/hadoop/schema/SchemaSource.java → ...in/venice/hadoop/schema/SchemaSource.java b/...in/venice/hadoop/schema/SchemaSource.java → ...in/venice/hadoop/schema/SchemaSource.java
diff --git a/...e/hadoop/schema/TestHDFSSchemaSource.java → ...e/hadoop/schema/TestHDFSSchemaSource.java b/...e/hadoop/schema/TestHDFSSchemaSource.java → ...e/hadoop/schema/TestHDFSSchemaSource.java
diff --git a/settings.gradle b/settings.gradle
@@ -54,6 +54,7 @@ include 'services:venice-standalone'
 include 'internal:venice-avro-compatibility-test'
 include 'internal:venice-client-common'
 include 'internal:venice-common'
+include 'internal:venice-hadoop-common'
 include 'internal:venice-jdk-compatibility-test'
 include 'internal:venice-test-common'