Rename .getStatsRecorder() to .getReadResponseStatsRecorder()

services/venice-server/src/main/java/com/linkedin/venice/grpc/GrpcIoRequestProcessor.java

@@ -116,7 +116,7 @@ public void processRequest(GrpcRequestContext requestContext) {
   }
 
   /**
-   * Call must ensure that all fields in the request context are properly set before invoking this method.
+   * Callers must ensure that all fields in the request context are properly set before invoking this method.
    * Callers must also use the appropriate {@link GrpcRequestContext#readResponseStatus} to comply with the API contract.
    *
    * @param requestContext The context of the request for which a response is being sent
@@ -265,10 +265,10 @@ public static void reportRequestStats(GrpcRequestContext requestContext) {
     if (readResponse == null) {
       requestStatsRecorder.setReadResponseStats(null).setResponseSize(0);
     } else if (readResponse.isFound()) {
-      requestStatsRecorder.setReadResponseStats(abstractReadResponse.getStatsRecorder())
+      requestStatsRecorder.setReadResponseStats(abstractReadResponse.getReadResponseStatsRecorder())
           .setResponseSize(abstractReadResponse.getResponseBody().readableBytes());
     } else {
-      requestStatsRecorder.setReadResponseStats(abstractReadResponse.getStatsRecorder()).setResponseSize(0);
+      requestStatsRecorder.setReadResponseStats(abstractReadResponse.getReadResponseStatsRecorder()).setResponseSize(0);
     }
 
     RequestStatsRecorder.recordRequestCompletionStats(requestContext.getRequestStatsRecorder(), true, -1);

services/venice-server/src/main/java/com/linkedin/venice/listener/OutboundHttpWrapperHandler.java

@@ -56,7 +56,7 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)
     try {
       if (msg instanceof AbstractReadResponse) {
         AbstractReadResponse obj = (AbstractReadResponse) msg;
-        requestStatsRecorder.setReadResponseStats(obj.getStatsRecorder());
+        requestStatsRecorder.setReadResponseStats(obj.getReadResponseStatsRecorder());
         compressionStrategy = obj.getCompressionStrategy();
         if (obj.isFound()) {
           body = obj.getResponseBody();

services/venice-server/src/main/java/com/linkedin/venice/listener/response/AbstractReadResponse.java

@@ -54,5 +54,5 @@ public boolean isFound() {
 
   public abstract int getResponseSchemaIdHeader();
 
-  public abstract ReadResponseStatsRecorder getStatsRecorder();
+  public abstract ReadResponseStatsRecorder getReadResponseStatsRecorder();
 }

services/venice-server/src/main/java/com/linkedin/venice/listener/response/MultiKeyResponseWrapper.java

@@ -59,7 +59,7 @@ public ReadResponseStats getStats() {
   }
 
   @Override
-  public ReadResponseStatsRecorder getStatsRecorder() {
+  public ReadResponseStatsRecorder getReadResponseStatsRecorder() {
     return this.responseStats;
   }
 

services/venice-server/src/main/java/com/linkedin/venice/listener/response/ParallelMultiKeyResponseWrapper.java

@@ -58,7 +58,7 @@ public ReadResponseStats getStats() {
   }
 
   @Override
-  public ReadResponseStatsRecorder getStatsRecorder() {
+  public ReadResponseStatsRecorder getReadResponseStatsRecorder() {
     return new CompositeReadResponseStatsRecorder(this.chunks);
   }
 
@@ -93,7 +93,7 @@ private static final class CompositeReadResponseStatsRecorder implements ReadRes
     private final ReadResponseStatsRecorder[] statsRecorders;
 
     CompositeReadResponseStatsRecorder(MultiKeyResponseWrapper[] responseChunks) {
-      this.mergedStats = responseChunks[0].getStatsRecorder();
+      this.mergedStats = responseChunks[0].getReadResponseStatsRecorder();
 
       /**
        * This array can be one element shorter than {@param responseChunks} because the first chunk's storage exec sub
@@ -102,7 +102,7 @@ private static final class CompositeReadResponseStatsRecorder implements ReadRes
       this.statsRecorders = new ReadResponseStatsRecorder[responseChunks.length - 1];
       ReadResponseStatsRecorder statsRecorder;
       for (int i = 1; i < responseChunks.length; i++) {
-        statsRecorder = responseChunks[i].getStatsRecorder();
+        statsRecorder = responseChunks[i].getReadResponseStatsRecorder();
         // We merge the stats of all chunks from the 2nd one to the last one into the stats of the 1st chunk.
         this.mergedStats.merge(statsRecorder);
 

services/venice-server/src/main/java/com/linkedin/venice/listener/response/SingleGetResponseWrapper.java

@@ -29,7 +29,7 @@ public ReadResponseStats getStats() {
   }
 
   @Override
-  public ReadResponseStatsRecorder getStatsRecorder() {
+  public ReadResponseStatsRecorder getReadResponseStatsRecorder() {
     return this.responseStats;
   }
 

services/venice-server/src/test/java/com/linkedin/venice/grpc/VeniceGrpcReadServiceImplTest.java

@@ -101,7 +101,6 @@ public void testIsServerHealthy() {
     assertTrue(response.getMessage().contains(VENICE_STORAGE_NODE_HARDWARE_IS_NOT_HEALTHY_MSG));
   }
 
-  // getCompressionDictionary
   @Test
   public void testGetCompressionDictionary() {
     String storeName = "testStore";
@@ -132,4 +131,9 @@ public void testGetCompressionDictionary() {
     CompressionDictionaryResponse exceptionActualResponse = blockingStub.getCompressionDictionary(request);
     assertEquals(exceptionActualResponse.getStatusCode(), VeniceReadResponseStatus.INTERNAL_SERVER_ERROR.getCode());
   }
+
+  @Test
+  public void testHandleAdminRequest() {
+
+  }
 }

services/venice-server/src/test/java/com/linkedin/venice/listener/StorageReadRequestHandlerTest.java

@@ -451,7 +451,7 @@ public void merge(ReadResponseStatsRecorder other) {
       }
 
       ServerHttpRequestStats stats = mock(ServerHttpRequestStats.class);
-      multiGetResponseWrapper.getStatsRecorder().recordMetrics(stats);
+      multiGetResponseWrapper.getReadResponseStatsRecorder().recordMetrics(stats);
       if (responseProvider == validResponseProvider) {
         verify(stats).recordSuccessRequestKeyCount(recordCount);
       }
@@ -727,7 +727,7 @@ public void testHandleComputeRequest(boolean readComputationEnabled) throws Exce
       double expectedReadComputeEfficiency = (double) valueBytes.length / (double) expectedReadComputeOutputSize;
 
       ServerHttpRequestStats stats = mock(ServerHttpRequestStats.class);
-      computeResponse.getStatsRecorder().recordMetrics(stats);
+      computeResponse.getReadResponseStatsRecorder().recordMetrics(stats);
       verify(stats).recordSuccessRequestKeyCount(keySet.size());
       verify(stats).recordDotProductCount(1);
       verify(stats).recordHadamardProduct(1);