[server][controller] Handle various exceptions #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1872
to
+1886
| try { | ||
| return producerAdapter.sendMessage( | ||
| topicPartition.getPubSubTopic().getName(), | ||
| topicPartition.getPartitionNumber(), | ||
| KafkaKey.HEART_BEAT, | ||
| kafkaMessageEnvelope, | ||
| getHeaders(kafkaMessageEnvelope.getProducerMetadata(), addLeaderCompleteState, leaderCompleteState), | ||
| callback); | ||
| } catch (Exception e) { | ||
| logger.error("Could not send heartbeat for topic {}", topicPartition.getPubSubTopic().getName()); | ||
| CompletableFuture<PubSubProduceResult> heartBeatFuture; | ||
| heartBeatFuture = new CompletableFuture<>(); | ||
| heartBeatFuture.completeExceptionally(e); | ||
| return heartBeatFuture; | ||
| } |
There was a problem hiding this comment.
This handling is also present in LFSIT#sendIngestionHeartbeat. Do we need it here as well?
adamxchen
reviewed
Aug 7, 2024
| final Store store = metadataRepository.getStoreOrThrow(storeName); | ||
| final Store store = metadataRepository.getStore(storeName); | ||
| if (store == null) { | ||
| LOGGER.error("Store {} not found in store repo.", storeName); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle various exception
Resolves exception handling.
How was this PR tested?
GHCI
Does this PR introduce any user-facing changes?