Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPERIMENTS] Quota rejection and it's impact on server latencies #1115

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

[EXPERIMENTS] Quota rejection and it's impact on server latencies #1115

wants to merge 26 commits into from

Conversation

sushantmane
Copy link
Contributor

[EXPERIMENTS] Quota rejection and it's impact on server latencies

Resolves #XXX

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@sushantmane
Threadpool for quota
a419089 
no flush in quota enforcement handler

Use separate thread pool for quota rejected request's response
@sushantmane
Revert "Threadpool for quota"
a1c3d34 
This reverts commit a419089.
@sushantmane
Add netty stats
01f42b1
@sushantmane
Add server connection stats
b6bcb3e
@sushantmane
Change log level to debug for ServerConnectionStatsHandler
57d08e8
@sushantmane
rename sensors
596c71e
@sushantmane
Measure writeAndFlushTime for quota rejected requests
37cb75b
@sushantmane
Add metrics for ResponseWriteAndFlushTimeForDataRequest
8d3accf
@sushantmane
Fix broken code
efd1489
@sushantmane
Add queuedTasksForReadHandler
16b70bd
@sushantmane
Add time spent in read handler
49a9c8f
@sushantmane
Add elapsed time
21e6f69
@sushantmane
Introduce write and flush handoff pool
0e89b97
@sushantmane
Revert "Introduce write and flush handoff pool"
b210502 
This reverts commit 0e89b97.
@sushantmane
Add back FlushConsolidationHandler
1e9fab0
@sushantmane
reduce flush consolidation to 16
e736e00
@sushantmane
Update connection stats
25a916d
@sushantmane
Add recordTimeSpentInQuotaEnforcement
78e4f45
@sushantmane
Skip flush in quota
09039a6
@sushantmane
Disable flush in channelReadCompletd
edae8d4
@sushantmane
Revert "Disable flush in channelReadCompletd"
8fd262e 
This reverts commit edae8d4.
@sushantmane
Revert "Skip flush in quota"
950083f 
This reverts commit 09039a6.
@sushantmane
Use expensive handlers only for acl and quota
e9fb60f
@sushantmane
Revert "Use expensive handlers only for acl and quota"
536ee95 
This reverts commit e9fb60f.
@sushantmane
[server][router] Replace synchronized with CAS in TokenBucket::update…
d8c5aaa 
… to reduce contention

Use old nextUpdateTimeVal in refillCount
@sushantmane
Delete unnecessary set
d99fafd
@sushantmane sushantmane marked this pull request as draft August 13, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sushantmane